stop using deprecated 2-element tuple format in sources, use equivalent dict format instead#4774
Merged
boegel merged 1 commit intoeasybuilders:developfrom Jun 26, 2017
Conversation
Member
Author
7bf3fbd to
197c4c7
Compare
…nt dict format instead
197c4c7 to
f1ee734
Compare
wpoely86
reviewed
Jun 25, 2017
| toolchain = {'name': 'dummy', 'version': ''} | ||
|
|
||
| sources = [('%(name)s.v%(version)s.jar', 'download')] | ||
| sources = ['%(name)s.v%(version)s.jar'] |
Member
Author
There was a problem hiding this comment.
Good question, I was wondering the exact same thing when I ran into it...
It's a bug, this syntax was used to specify a custom extract command, but since the JAR easyblock just skips the extract step this went unnoticed.
Member
Author
|
Thanks for the review @wpoely86! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cfr. http://easybuild.readthedocs.io/en/develop/Deprecated-functionality.html#depr-sources-2-element-tuple
requires
easybuilders/easybuild-framework#2223