fix reference to github.com/hpcugent in GROMACS easyconfig#4837
Merged
verdurin merged 1 commit intoeasybuilders:developfrom Jul 9, 2017
Merged
fix reference to github.com/hpcugent in GROMACS easyconfig#4837verdurin merged 1 commit intoeasybuilders:developfrom
verdurin merged 1 commit intoeasybuilders:developfrom
Conversation
This was referenced Jul 8, 2017
Member
|
@boegel no, I didn't see the notification, which is why I went ahead and merged. I thought this one was recent enough to have picked up the style checks, but clearly not. |
Member
Author
|
@verdurin To clarify: Travis has send you a notification after merging the PR (for the merge commit), but to a |
Member
|
Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were broken in
developafter #4585 was merged (cc @verdurin).@easybuilders/easybuild-easyconfigs-maintainers The tests have been made stricter recently (e.g. style tests), so it's important to re-trigger tests for PRs that were tested a while ago (by closing/opening the PR, Travis supports no other way of re-triggering tests without adding an extra commit...).
I'll look into better Travis notifications, since I wasn't notified of the breakage either; were you @verdurin?