{tools}[GCCcore/6.4.0] ncompress v4.2.4.4#4852
Conversation
|
|
||
| toolchain = {'name': 'GCCcore', 'version': '6.4.0'} | ||
|
|
||
| # https://github.com/vapier/ncompress/archive/v4.2.4.4.tar.gz |
| # https://github.com/vapier/ncompress/archive/v4.2.4.4.tar.gz | ||
| source_urls = ['https://github.com/vapier/ncompress/archive/'] | ||
| sources = ['%(name)s-%(version)s.tar.gz'] | ||
|
|
| DESTDIR=%(installdir)s\ | ||
| BINDIR=/bin\ | ||
| MANDIR=/man/man1\ | ||
| """ |
There was a problem hiding this comment.
Add one line at a time to installopts with the += operator.
There was a problem hiding this comment.
Or just collapse to a single line, I see no reason to spread this across multiple lines? In fact, the trailing \ characters are confusing imho...
installopts = "DESTDIR=%(installdir)s BINDIR=/bin MANDIR=/man/man1"| toolchain = {'name': 'GCCcore', 'version': '6.4.0'} | ||
|
|
||
| source_urls = ['https://github.com/vapier/ncompress/archive/'] | ||
| sources = ['%(name)s-%(version)s.tar.gz'] |
There was a problem hiding this comment.
download fails for me, should be v%(version)s.tar.gz?
There was a problem hiding this comment.
I wish there was a GITHUB_SOURCE template. :) Github is always confusing. I think there is a way (sometimes) to retrieve using the full SOURCE_TAR_GZ. In my browser if I click the v4.2.4.4.tar.gz it somehow manages to save it using the SOURCE_TAR_GZ name (and not just the v%(version).tar.gz name.
There was a problem hiding this comment.
Yes, it does a sort of rename, maybe if you use the releases URL rather than archive?
We actually have a template for GitHub URLs, i.e. GITHUB_SOURCE see easybuilders/easybuild-framework#1872.
It hasn't been used much though, and it has the caveat of also needing to define github_account = '...' in the easyconfig file...
| DESTDIR=%(installdir)s\ | ||
| BINDIR=/bin\ | ||
| MANDIR=/man/man1\ | ||
| """ |
There was a problem hiding this comment.
Or just collapse to a single line, I see no reason to spread this across multiple lines? In fact, the trailing \ characters are confusing imho...
installopts = "DESTDIR=%(installdir)s BINDIR=/bin MANDIR=/man/man1"|
Y'all are gonna luv my Mesa/17.1.2.... it has configopts that go on and on and.. I think this is clearer even if the backslashes take some getting used to. |
|
@JackPerdue Consistent style across easyconfigs beats personal preferences imho. We're not using this multi-line style anywhere right now... |
|
Test report by @boegel |
|
Going in, thanks @JackPerdue! |
|
Test report by @boegel |
(created using
eb --new-pr)