Skip to content

Openbabel#504

Merged
boegel merged 16 commits intoeasybuilders:developfrom
wpoely86:openbabel
Nov 12, 2013
Merged

Openbabel#504
boegel merged 16 commits intoeasybuilders:developfrom
wpoely86:openbabel

Conversation

@wpoely86
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 commented Nov 8, 2013

Added OpenBabel

Depends on easybuilders/easybuild-easyblocks#299

@hpcugentbot
Copy link
Copy Markdown

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 8, 2013

ok to test

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EasyBuild will do exactly this by default, so drop this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a left over from the previous easyconfig by Toon. I have reworked the easyblock too but I still need to push that.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 8, 2013

Jenkins: retest this please

Added some comments to the patches and fix hardcoded version in the
easyconfig.
@boegel boegel mentioned this pull request Nov 9, 2013
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 10, 2013

As @wpoely86 mentioned in #465, wxWidgets is a missing dependency here to make OpenBabel feature-complete.
@wpoely86: are you planning to look into that?

@wpoely86
Copy link
Copy Markdown
Member Author

I don't have the time for the moment. Maybe later but no promises...

@wpoely86
Copy link
Copy Markdown
Member Author

In principle, cairo is also a (optional) dep. I've got a bunch of errors all around try to update cairo to work with this PR. For wxWidgets, an EB for GTK+ is also missing.

@boegel a hackaton with the sole purpose to write EB's for X related stuff?

@fgeorgatos
Copy link
Copy Markdown
Contributor

On Mon, Nov 11, 2013 at 12:24 PM, wpoely86 [email protected] wrote:

@boegel https://github.com/boegel a hackathon with the sole purpose to
write EB's for X related stuff?

I could well chime-in for a "1-day minithon", if you could plan it
considering this:
http://bbc2013.ibsquare.be/

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 11, 2013

@wpoely86: If you feel this should go in without the wxWidgets and cairo deps, let me know, and I'll try and get it in for EB v1.9.0.
All these GUI deps are usually quite a bit of a PITA, so maybe we shouldn't stall stuff because of them.

Mini-hackathon on whatever topic: fine by me, time permitting.

@wpoely86
Copy link
Copy Markdown
Member Author

@boegel I would merge it in. The cairo dep is optional. This package is useful without it.

@fgeorgatos
Copy link
Copy Markdown
Contributor

Dependencies not met. Cannot resolve ["libpng/1.6.3-ictce-4.1.13...

could it be that some other sub-dependency missing triggers this?

ps.
69f0872 message is visible by clicking above on the "x" and the checking console output;
as boegel explained later on, this was sitting on a broken develop, therefor simply ignore.

@wpoely86
Copy link
Copy Markdown
Member Author

@fgeorgatos This is strange because I use ictce-5.5.0. I don't even have that package, only libpng/1.6.6-ictce-5.5.0.

I don't see which dep could be pulling libpng in...

@wpoely86
Copy link
Copy Markdown
Member Author

OK, this libpng dep error is not related to this PR. There is a dep error in the WPS EB's. Why does this show up here?

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 12, 2013

Jenkins: please test this

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use (namelower)s here (twice)

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 12, 2013

@wpoely86, @fgeorgatos: The test failed because it was run on top of a broken develop branch, it has nothing to do with this PR... As soon as @wpoely86 fixes the open remarks, things should go green again...

@wpoely86
Copy link
Copy Markdown
Member Author

Good to go!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not set this in the easyblock it's always needed, and omitting it would break the build...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wpoely86: one more, use %(version)s here

@boegel boegel merged commit 96cafc9 into easybuilders:develop Nov 12, 2013
@wpoely86 wpoely86 deleted the openbabel branch November 13, 2013 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants