Skip to content

remove superfluous $CPATH update in GLib 2.44.0 easyconfig#5053

Merged
verdurin merged 1 commit intoeasybuilders:developfrom
boegel:GLib_no_CPATH
Aug 21, 2017
Merged

remove superfluous $CPATH update in GLib 2.44.0 easyconfig#5053
verdurin merged 1 commit intoeasybuilders:developfrom
boegel:GLib_no_CPATH

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 21, 2017

After checking, it's not needed at all to update $CPATH like this for GLib...

(see also https://github.com/easybuilders/easybuild-easyconfigs/pull/5037/files#r134147655)

This is the only GLib easyconfig that includes this.

@boegel boegel added this to the 3.4.0 milestone Aug 21, 2017
@boegel boegel requested a review from verdurin August 21, 2017 11:53
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 21, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2650.swalot.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/f19b79ef27156e15320998ad22c11aee for a full test report.

Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Copy Markdown
Member

Going in, thanks @boegel!

@verdurin verdurin merged commit b79bf29 into easybuilders:develop Aug 21, 2017
@boegel boegel deleted the GLib_no_CPATH branch August 21, 2017 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants