Skip to content

add easyconfig file for Vampir#512

Merged
boegel merged 22 commits intoeasybuilders:developfrom
boegel:unite_Vampir
Jun 25, 2015
Merged

add easyconfig file for Vampir#512
boegel merged 22 commits intoeasybuilders:developfrom
boegel:unite_Vampir

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 8, 2013

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I remember correctly, this is an opportunity for %(version)s constructs and such, no?

otherwise: visual review looks fine

@berndmohr
Copy link
Copy Markdown

as fgeorgatos explained, remove version number hardcoding in install_cmd, otherwise fine

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 12, 2013

Apparently, the combination of --silent and --instdir don't work out well... --silent is only intended to be used with the default settings, and --instdir overrides a default setting.
I fear an easyblock is the only way here, because with --instdir the installation becomes interactive...

@berndmohr: thoughts?

@berndmohr
Copy link
Copy Markdown

Weird. Works fine on my laptop:

% cp /opt/local/unite-installer-1.1/packages/vampir-8.1.0-standard-linux-x86_64-setup.bin .

% chmod 700 vampir-8.1.0-standard-linux-x86_64-setup.bin 

% ./vampir-8.1.0-standard-linux-x86_64-setup.bin --silent --instdir=/tmp/va81
Unpacking...
Installing...
Cleaning...

% ls -lR /tmp/va81
/tmp/va81:
total 8
drwxr-xr-x 2 mohr zam 4096 Nov 12 23:04 bin
drwxr-xr-x 2 mohr zam 4096 Nov 12 23:04 doc

/tmp/va81/bin:
total 24948
-rwxr-xr-x 1 mohr zam 25511424 Jun 26 14:06 vampir

/tmp/va81/doc:
total 8308
-rw-r--r-- 1 mohr zam 8478864 Jun 26 14:06 vampir-manual.pdf
-rw-r--r-- 1 mohr zam    7160 Jun 26 14:06 vampir-release-notes.txt

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed; if you like it better, try (or template it with a variable):
install_cmd = "./" + sources[0] + " --silent --instdir=%(installdir)s"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been reviewed some time ago;
I still recommend the following construct, for compactness/maintainability:
install_cmd = "./" + sources[0] + " --silent --instdir=%(installdir)s"
re-testing recommended.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional options need to be passed to the install command as well; @geimer is looking into it

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 13, 2013

@berndmohr: I'm forced to use the demo version of Vampir, I guess that's where the problem is coming from. Apparently the demo installer behaves differently (why?!?)...
Can you try the demo version on your end, and see if you can reproduce my problem?

@berndmohr
Copy link
Copy Markdown

@boegel: No, the demo version works for me too:

% ./vampir-8.1.0-demo-linux-x86_64-setup.bin --silent --instdir=/tmp/va81
Unpacking...
Installing...
Cleaning...

But there is another issue with it: Can you make the easyconfig work that it either can use
./vampir-8.1.0-demo-linux-x86_64-setup.bin or ./vampir-8.1.0-standard-linux-x86_64-setup.bin?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 13, 2013

No, you'd have to create a separate easyconfig for that today. You'd probably want to make sure which of both you're installing.

If the demo version works for you, then I guess the standard installer would also break on my end when I'm trying to combine --silent with --instdir... I'll try and see if I can figure out what goes wrong.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 13, 2013

I haven't been able to figure out why this doesn't work on my end, so I'll have to look into this one again later..

Can somebody confirm the md5sum on the demo installer?

$ md5sum vampir-8.1.0-demo-linux-x86_64-setup.bin 
2234b91bdc54c4f2fce008f0f0e8f418  vampir-8.1.0-demo-linux-x86_64-setup.bin

@berndmohr
Copy link
Copy Markdown

@boegel: confirmed

zam1260:~ [109] md5sum vampir-8.1.0-demo-linux-x86_64-setup.bin
2234b91bdc54c4f2fce008f0f0e8f418  vampir-8.1.0-demo-linux-x86_64-setup.bin

@fgeorgatos
Copy link
Copy Markdown
Contributor

and same md5sum over here.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 18, 2013

Apparently I never shared the exact output I'm seeing, so here it comes.

I've asked on of the Vampir people who's around here at SC13 what may be causing this, and I'll point him here.

using --silent and --instdir together doesn't work

$ ./vampir-8.1.0-demo-linux-x86_64-setup.bin --silent --instdir=/tmp
Unpacking...
Installing...
Error: The installation of Vampir failed.
$ echo $?
1

only using --instdir and answering the (silly) question does work


$ ./vampir-8.1.0-demo-linux-x86_64-setup.bin --instdir=/tmp

Dear customer, 
you  will now be guided  through the installation  of Vampir  step by step.
Please  answer the following questions.  Default answers to these questions
are provided  in brackets.  Please  confirm  the default answers  by simply
pressing the 'enter' key on your keyboard. Alternatively, you can enter the
appropriate settings for your system.  Contact your system administrator if
you are not sure about the right answers.

Do you want to install Vampir to /tmp? [y/N]: y

Unpacking...
Installing...
Cleaning...
$ ls -lrt /tmp/bin/vampir 
-rwxr-xr-x 1 vsc40023 vsc40023 24740528 Nov  7 08:27 /tmp/bin/vampir

@bertwesarg
Copy link
Copy Markdown

Can you run the install script inside an 'set -x' shell and send the output, like:

sh -x ./vampir-8.1.0-demo-linux-x86_64-setup.bin --silent --instdir=/tmp

Thanks.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 19, 2013

@bertwesarg:

+ set -e
+ umask 022
+ SCRIPT_LINES=433
+ VAMPIR_VERSION=8.1.0
+ BASENAME=vampir-8.1.0
+ TEMP_DIR=/tmp/vampir
+ SETUP_STATE=error
+ trap exit_trap EXIT
+ trap abort_setup INT
+ INSTDIR=/opt/local/vampir-8.1.0
++ id -u
+ USER_ID=2540023
+ IS_ROOT=false
+ '[' 2540023 -eq 0 ']'
+ INSTDIR=/user/home/gent/vsc400/vsc40023/vampir-8.1.0
+ DESKTOP_ICON=1
+ MENU_ITEMS=1
+ TRACE_FILES=1
+ CREATE_TAR=0
+ CREATE_RPM=0
+ SILENT=true
+ SHOW_HELP=0
+ for WORD in '"$@"'
+ case $WORD in
+ SILENT=false
+ for WORD in '"$@"'
+ case $WORD in
++ echo --instdir=/tmp
++ sed -e 's/.*=//g'
+ INSTDIR=/tmp
+ '[' 0 -eq 1 ']'
+ HAS_RELPATH=false
+ case "${INSTDIR}" in
+ READ_ARCHIVE='tail -n +433 ./vampir-8.1.0-demo-linux-x86_64-setup.bin'
+ '[' 0 -eq 1 ']'
+ false
+ echo Unpacking...
Unpacking...
+ '[' '!' -d /tmp/vampir/vampir ']'
+ mkdir -p /tmp/vampir/vampir
+ '[' 0 -eq 1 ']'
+ unpack_package /tmp
+ local tmpdir=/tmp/tmp.26667
+ mkdir -p /tmp/tmp.26667
+ tail -n +433 ./vampir-8.1.0-demo-linux-x86_64-setup.bin
+ gzip -dc
+ cd /tmp/tmp.26667
+ tar -x
++ cd /tmp/tmp.26667/vampir
++ find . -type d
+ dirlist='.
./icons
./bin
./doc'
+ for d in '${dirlist}'
+ mkdir -p /tmp/.
+ for d in '${dirlist}'
+ mkdir -p /tmp/./icons
+ for d in '${dirlist}'
+ mkdir -p /tmp/./bin
+ for d in '${dirlist}'
+ mkdir -p /tmp/./doc
++ cd /tmp/tmp.26667/vampir
++ find . -type f
+ filelist='./icons/32x32.png
./icons/128x128.png
./icons/64x64.png
./icons/48x48.png
./icons/16x16.png
./bin/vampir
./doc/vampir-release-notes.txt
./doc/vampir-manual.pdf'
+ for f in '${filelist}'
+ mv /tmp/tmp.26667/vampir/./icons/32x32.png /tmp/./icons/32x32.png
+ for f in '${filelist}'
+ mv /tmp/tmp.26667/vampir/./icons/128x128.png /tmp/./icons/128x128.png
+ for f in '${filelist}'
+ mv /tmp/tmp.26667/vampir/./icons/64x64.png /tmp/./icons/64x64.png
+ for f in '${filelist}'
+ mv /tmp/tmp.26667/vampir/./icons/48x48.png /tmp/./icons/48x48.png
+ for f in '${filelist}'
+ mv /tmp/tmp.26667/vampir/./icons/16x16.png /tmp/./icons/16x16.png
+ for f in '${filelist}'
+ mv /tmp/tmp.26667/vampir/./bin/vampir /tmp/./bin/vampir
+ for f in '${filelist}'
+ mv /tmp/tmp.26667/vampir/./doc/vampir-release-notes.txt /tmp/./doc/vampir-release-notes.txt
+ for f in '${filelist}'
+ mv /tmp/tmp.26667/vampir/./doc/vampir-manual.pdf /tmp/./doc/vampir-manual.pdf
+ rm -rf /tmp/tmp.26667
+ echo Installing...
Installing...
+ chmod 755 /tmp/bin/vampir
+ XDG_MODE=
+ false
+ for i in 16 32 48 64 128
+ '[' 1 -eq 1 ']'
+ xdg-icon-resource install --size 16 /tmp/icons/16x16.png application-x-vampir
+ exit_trap
+ rm -rf /tmp/vampir
+ case ${SETUP_STATE} in
+ '[' 0 -eq 1 ']'
+ '[' 0 -eq 1 ']'
+ echo 'Error: The installation of Vampir failed.'
Error: The installation of Vampir failed.
+ false

Is it just a matter of $SETUP_STATE not being set correctly? And if so, why doesn't @berndmohr see it? Just a quick guess after peeking at the output, I might be seeing ghosts.

@bertwesarg
Copy link
Copy Markdown

The rm -rf /tmp/vampir seems wrong. It should have removed the /tmp/tmp.26667 directory. I'm pointing this issue to our team and as it is now 8 am in Germany you should have a solution when you wake up tomorrow.

@bertwesarg
Copy link
Copy Markdown

Actually, I now see that the command xdg-icon-resource install … triggers our exit trap, so probably you don't have the xdg-icon-resource command available.

@ronaldgeisler
Copy link
Copy Markdown

@boegel use --no-icon --no-menu-items --no-trace-file-association
@bertwesarg the silent mode doesn't check the availability of the xdg utilities

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 19, 2013

@bertwesarg, @ronaldgeisler: OK, thanks for the feedback. Shouldn't Vampir be spitting out something more meaningful though, i.e.simply mention that the xdg utillties are not available, and how that can be resolved (by installing them, or by adding the extra options @ronaldgeisler mentioned)?

@boegel boegel modified the milestones: v1.11, v1.10 Feb 15, 2014
@boegel boegel modified the milestones: v1.12, v1.11 Mar 14, 2014
@fgeorgatos
Copy link
Copy Markdown
Contributor

somebody (@boegel ;-) ) was asking for a review of this;
I find the PR ready/elegant enough to receive a pass...

@fgeorgatos
Copy link
Copy Markdown
Contributor

Test report by @fgeorgatos
FAILED
Build succeeded for 0 out of 1
Linux debian 6.0.10, Intel(R) Xeon(R) CPU L5640 @ 2.27GHz, Python 2.6.6
See https://gist.github.com/aec9d935140a500d6f7a for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 3, 2015

Jenkins: test this please

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3470/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3470/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 17, 2015

requires boegel#8 (thanks @geimer!)

@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3636/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3636/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel modified the milestone: v1.15 Jun 24, 2015
@hpcugentbot
Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3645/
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/3645/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 25, 2015

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
Linux SL 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/ba35119285c94bf48730 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jun 25, 2015

Good to go, thanks for picking this up again @geimer!

boegel added a commit that referenced this pull request Jun 25, 2015
add easyconfig file for Vampir
@boegel boegel merged commit ce0ba31 into easybuilders:develop Jun 25, 2015
@boegel boegel deleted the unite_Vampir branch June 25, 2015 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants