add easyconfig file for Vampir#512
Conversation
There was a problem hiding this comment.
if I remember correctly, this is an opportunity for %(version)s constructs and such, no?
otherwise: visual review looks fine
|
as fgeorgatos explained, remove version number hardcoding in install_cmd, otherwise fine |
|
Apparently, the combination of @berndmohr: thoughts? |
|
Weird. Works fine on my laptop: |
There was a problem hiding this comment.
reviewed; if you like it better, try (or template it with a variable):
install_cmd = "./" + sources[0] + " --silent --instdir=%(installdir)s"
There was a problem hiding this comment.
this has been reviewed some time ago;
I still recommend the following construct, for compactness/maintainability:
install_cmd = "./" + sources[0] + " --silent --instdir=%(installdir)s"
re-testing recommended.
There was a problem hiding this comment.
additional options need to be passed to the install command as well; @geimer is looking into it
|
@berndmohr: I'm forced to use the |
|
@boegel: No, the demo version works for me too: But there is another issue with it: Can you make the easyconfig work that it either can use |
|
No, you'd have to create a separate easyconfig for that today. You'd probably want to make sure which of both you're installing. If the |
|
I haven't been able to figure out why this doesn't work on my end, so I'll have to look into this one again later.. Can somebody confirm the md5sum on the demo installer? |
|
@boegel: confirmed |
|
and same md5sum over here. |
|
Apparently I never shared the exact output I'm seeing, so here it comes. I've asked on of the Vampir people who's around here at SC13 what may be causing this, and I'll point him here. using --silent and --instdir together doesn't work only using --instdir and answering the (silly) question does work |
|
Can you run the install script inside an 'set -x' shell and send the output, like: Thanks. |
Is it just a matter of |
|
The |
|
Actually, I now see that the command |
|
@boegel use |
|
@bertwesarg, @ronaldgeisler: OK, thanks for the feedback. Shouldn't Vampir be spitting out something more meaningful though, i.e.simply mention that the xdg utillties are not available, and how that can be resolved (by installing them, or by adding the extra options @ronaldgeisler mentioned)? |
|
somebody (@boegel ;-) ) was asking for a review of this; |
|
Test report by @fgeorgatos |
|
Jenkins: test this please |
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Refer to this link for build results (access rights to CI server needed): This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Test report by @boegel |
|
Good to go, thanks for picking this up again @geimer! |
this easyconfig is contributed by @berndmohr via https://github.com/fgeorgatos/easybuild.experimental/tree/master/users/unite