Skip to content

fix checksums for packages that download from github.com/x/y/archive#5162

Merged
wpoely86 merged 2 commits intoeasybuilders:developfrom
boegel:fix_checksums_github_archive
Sep 26, 2017
Merged

fix checksums for packages that download from github.com/x/y/archive#5162
wpoely86 merged 2 commits intoeasybuilders:developfrom
boegel:fix_checksums_github_archive

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 22, 2017 •
edited
Loading

see #5151

Short-term, the easiest thing to do is just to fix the checksums.

I looked at all easyconfigs that i) download from github.com/x/y/archive (561), and ii) already include checksums (84 of those 561).

So all in all, the damage by the changed checksums for tarball generated by GitHub isn't too bad, but that's mostly because we don't have checksums in place everywhere yet...

In the long term, we should try to figure out a better way of dealing with this, to avoid being hit by this in case it occurs again (follow-up on that in #5151).

edit: requires easybuilders/easybuild-easyblocks#1257 and easybuilders/easybuild-easyblocks#1258

@boegel boegel added this to the 3.4.1 milestone Sep 22, 2017
This was referenced Sep 22, 2017
Open
Merged
boegel
boegel commented Sep 24, 2017
View reviewed changes
Comment thread easybuild/easyconfigs/m/MXNet/MXNet-0.9.3-foss-2016b-Python-2.7.12-R-3.3.3.eb
"3dc48183e123c650707bcf26a9254941", # c29ac58320d7b0.tar.gz
"fb04cb1694f1e66591a31a18bc92b451", # 0d64855f741e04.tar.gz
"da873c881758c0e10ac0928f86568456", # b32ec4aee65a66.tar.gz
'c8d1e6d8a178e475625e60a8fd71b49efbd7c8a2b222300858f50201d89127e3', # v0.9.3.tar.gz
Copy link
Copy Markdown
Member Author

@boegel boegel Sep 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently this new tarball is different than the one that was previously available, i.e. it now contains a directory named incubator-mxnet-0.9.3 whereas before it contained a directory named mxnet-0.9.3...

Because of this, the MXNet easyblock needs to be updated, see easybuilders/easybuild-easyblocks#1257

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 24, 2017

Test report by @boegel
FAILED
Build succeeded for 14 out of 18 (18 easyconfigs in this PR)
node2017.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/0d705e690a0dbacad23e0a3bea23032e for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 26, 2017

Test report by @boegel
SUCCESS
Build succeeded for 18 out of 18 (18 easyconfigs in this PR)
node2014.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/0e1ae02bcab09b3111e9620f88765648 for a full test report.

@wpoely86 wpoely86 merged commit 686edda into easybuilders:develop Sep 26, 2017
@boegel boegel deleted the fix_checksums_github_archive branch September 26, 2017 06:54
@boegel boegel mentioned this pull request Sep 29, 2017
Closed
@boegel boegel mentioned this pull request Oct 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpoely86 wpoely86 wpoely86 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.4.1

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @wpoely86