Skip to content

disable optarch when using intel compilers and enable tests in all libxc-2.2.3 easyconfigs#5257

Merged
boegel merged 2 commits intoeasybuilders:developfrom
migueldiascosta:20171024112855_new_pr_libxc223
Oct 24, 2017
Merged

disable optarch when using intel compilers and enable tests in all libxc-2.2.3 easyconfigs#5257
boegel merged 2 commits intoeasybuilders:developfrom
migueldiascosta:20171024112855_new_pr_libxc223

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

(created using eb --new-pr)

@migueldiascosta
Copy link
Copy Markdown
Member Author

Test report by @migueldiascosta
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
grc-cluster1 - Linux centos 6.9, Intel(R) Xeon(R) CPU E5-2640 0 @ 2.50GHz, Python 2.6.6
See https://gist.github.com/07abc7197279c6b679b11e26046f7445 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member Author

Test report by @migueldiascosta
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
grc-e11 - Linux centos 6.9, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.6.6
See https://gist.github.com/37254e70d053948f5da171173d47ce68 for a full test report.

verdurin
verdurin previously approved these changes Oct 24, 2017
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@verdurin
Copy link
Copy Markdown
Member

Can't run tests easily at the moment, though...

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 24, 2017

@migueldiascosta optarch is not set to False in 1st easyconfig?

Also, maybe include a comment to mention why it's disabled? I'd mention failing tests on Haswell?

@boegel boegel added this to the 3.5.0 milestone Oct 24, 2017
@migueldiascosta
Copy link
Copy Markdown
Member Author

@boegel the tests only fail with optarch True with Intel compilers (-xHost) on Haswell's (and above, I assume, the problem is likely with the avx2 extensions)

I'll add the comment

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 24, 2017

@migueldiascosta AVX2 should also be used when using GCC with optarch enabled... But the problem may be specific to Intel compilers, sure.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 24, 2017

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2045.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/b2ad00b2f6e802884d3b8049eb2565e5 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 24, 2017

Test report by @boegel
FAILED
Build succeeded for 7 out of 8 (3 easyconfigs in this PR)
node2579.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/4c498b9d34c97e795b9791e9e4cd4dff for a full test report.

edit: failed with segfaults because buggy libintlc.so.5 was being used, cfr. #3646 (comment)

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 24, 2017

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2594.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/b5104c857bc1797f5289379e64a2be6a for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 24, 2017

Going in, thanks @migueldiascosta!

@boegel boegel merged commit 716c1c6 into easybuilders:develop Oct 24, 2017
@migueldiascosta migueldiascosta deleted the 20171024112855_new_pr_libxc223 branch October 2, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants