Skip to content

{bio}[intel/2017b] FALCON v1.8.8#5265

Merged
wpoely86 merged 3 commits intoeasybuilders:developfrom
boegel:20171025183609_new_pr_FALCON188
Dec 7, 2017
Merged

{bio}[intel/2017b] FALCON v1.8.8#5265
wpoely86 merged 3 commits intoeasybuilders:developfrom
boegel:20171025183609_new_pr_FALCON188

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 25, 2017 •
edited
Loading

(created using eb --new-pr)

edit: requires easybuilders/easybuild-easyblocks#1285 for per-component checksums to be picked up

@boegel boegel changed the title {bio}[intel/2017b] FALCON v1.8.8 {bio}[intel/2017b] FALCON v1.8.8 (WIP) Oct 25, 2017
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 25, 2017

(marked as WIP because I'm awaiting feedback from the person who requested this to be installed)

@vanzod, @verdurin: Are you guys up for taking a look at this, and maybe testing it, since it seems to be in the domain your cater to?

I did the best I could to untangle the rather messy installation procedure, and deliberate stayed away from their custom install tool FALCON-integrate (which calls FALCON-make, etc.)...

@vanzod
Copy link
Copy Markdown
Member

vanzod commented Oct 25, 2017

Test report by @vanzod
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
cermis - Linux debian 8.8, Intel(R) Xeon(R) CPU E5620 @ 2.40GHz, Python 2.7.9
See https://gist.github.com/4c5687e686643ba9f121e01e58e7e263 for a full test report.

vanzod
vanzod previously requested changes Oct 25, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@vanzod vanzod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing checksums for components.
EB will fail if --enforce-checksums is used.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 3, 2017

@boegel style problem:

/home/travis/build/easybuilders/easybuild-easyconfigs/easybuild/easyconfigs/f/FALCON/FALCON-1.8.8-intel-2017b.eb:89:110: E261 at least two spaces before inline comment

@boegel boegel mentioned this pull request Nov 4, 2017
Merged
@boegel boegel added the new label Nov 4, 2017
@boegel boegel added this to the 3.5.0 milestone Nov 4, 2017
@easybuilders easybuilders deleted a comment from boegelbot Nov 4, 2017
@boegel boegel changed the title {bio}[intel/2017b] FALCON v1.8.8 (WIP) {bio}[intel/2017b] FALCON v1.8.8 Dec 6, 2017
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 6, 2017

@easybuilders/easybuild-easyconfigs-maintainers Should be good to go now..

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 6, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2404.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/b81fb7573dbb7531f99a0217ba82408e for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 6, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2029.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/00d0a879fc6b40fc5b378f83a3116855 for a full test report.

@wpoely86 wpoely86 dismissed vanzod’s stale review December 7, 2017 20:32

checksums added

@wpoely86 wpoely86 merged commit 2decd0d into easybuilders:develop Dec 7, 2017
@boegel boegel deleted the 20171025183609_new_pr_FALCON188 branch December 7, 2017 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpoely86 wpoely86 wpoely86 approved these changes

@vanzod vanzod vanzod left review comments

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@boegel @vanzod @verdurin @wpoely86