Skip to content

{bio}[intel/2017b] CIRI v2.0.6#5358

Merged
verdurin merged 1 commit intoeasybuilders:developfrom
boegel:20171117154708_new_pr_CIRI206
Nov 17, 2017
Merged

{bio}[intel/2017b] CIRI v2.0.6#5358
verdurin merged 1 commit intoeasybuilders:developfrom
boegel:20171117154708_new_pr_CIRI206

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 17, 2017

(created using eb --new-pr)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 17, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2612.swalot.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/ccd1be9982aca63c9918122c3f464b62 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 17, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2080.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/03ec464debbd0122406310a9b90d124c for a full test report.

@boegel boegel added the new label Nov 17, 2017
@boegel boegel added this to the 3.5.0 milestone Nov 17, 2017
wpoely86
wpoely86 reviewed Nov 17, 2017
View reviewed changes
Comment thread easybuild/easyconfigs/c/CIRI/CIRI-2.0.6-intel-2017b-Perl-5.26.0.eb
'dirs': ['data'],
}

modloadmsg = "To use CIRI, run 'perl $EBROOTCIRI/CIRI%(version_major)s.pl ...'\n"
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 Nov 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not make it executable and add in $PATH?

Copy link
Copy Markdown
Member Author

@boegel boegel Nov 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the software's documentation says "run perl CIRI2.pl, so people won't try to run CIRI2.pl directly, they'll try to run perl CIRI2.pl which will still fail even if the location of CIRI2.pl is in $PATH...

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 17, 2017

Test report by @verdurin
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in this PR)
rescomp1 - Linux centos 6.8, Intel(R) Xeon(R) CPU E5-2650 v2 @ 2.60GHz, Python 2.7.14
See https://gist.github.com/0eb4b21e654c461b890c7eea0762dbc9 for a full test report.

verdurin
verdurin approved these changes Nov 17, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 17, 2017

Going in, thanks @boegel!

@verdurin verdurin merged commit d92b573 into easybuilders:develop Nov 17, 2017
@boegel boegel deleted the 20171117154708_new_pr_CIRI206 branch November 17, 2017 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpoely86 wpoely86 wpoely86 left review comments

@verdurin verdurin verdurin approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @verdurin @wpoely86