Skip to content

{vis}[dummy/] HDFView v2.14#5391

Merged
migueldiascosta merged 3 commits intoeasybuilders:developfrom
boegel:20171122225324_new_pr_HDFView214
Nov 24, 2017
Merged

{vis}[dummy/] HDFView v2.14#5391
migueldiascosta merged 3 commits intoeasybuilders:developfrom
boegel:20171122225324_new_pr_HDFView214

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 22, 2017

(created using eb --new-pr)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 22, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2461.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/692fb9fac3b9ac8d5e187cf34aa85367 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 22, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2031.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/2fade8de381286f9f602c2b6d439a2f2 for a full test report.


toolchain = {'name': 'dummy', 'version': ''}

source_urls = ['http://support.hdfgroup.org/ftp/HDF5/hdf-java/current/bin/']
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

download fails (404), works via https

toolchain = {'name': 'dummy', 'version': ''}

source_urls = ['http://support.hdfgroup.org/ftp/HDF5/hdf-java/current/bin/']
sources = ['%(name)s-%(version)s-centos7_64.tar.gz']
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this package requires glibc 2.14, otherwise it works but doesn't support hdf5; should use centos6 package in systems with glibc 2.12

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, should we include centos7 in the versionsuffix?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw some (old) CUDA easyconfigs where the OS_NAME and OS_VERSION is used to select the package, not sure if this is a good practice

otherwise yes, include centos7 in the versionsuffix (and add an another easyconfig for centos6)?

@boegel boegel added the new label Nov 23, 2017
@boegel boegel added this to the 3.5.0 milestone Nov 23, 2017
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 23, 2017

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2461.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/db59dc69336c47c17cf4d0ef197dd642 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 23, 2017

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
gligar02.gligar.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/2351b62949e888a8046fe85a85a48fac for a full test report.

Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit d4f313e into easybuilders:develop Nov 24, 2017
@boegel boegel deleted the 20171122225324_new_pr_HDFView214 branch November 24, 2017 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants