Skip to content

{bio}[foss/2016b] fastq-tools 0.8#5396

Merged
boegel merged 7 commits intoeasybuilders:developfrom
SethosII:fastq-tools
Jun 29, 2018
Merged

{bio}[foss/2016b] fastq-tools 0.8#5396
boegel merged 7 commits intoeasybuilders:developfrom
SethosII:fastq-tools

Conversation

@SethosII
Copy link
Copy Markdown
Contributor

This adds fastq-tools.

I had one issue with the easyconfig during the build. The LIBS variable somehow becomes LIBS = -lm -lpthread-lm and this obviously results in error: cannot find -lpthread-lm during linking. Here is the log of the build: easybuild-fastq-tools-0.8-20171123.134323.HYgMZ.log

@SethosII
Copy link
Copy Markdown
Contributor Author

Hm, the travis build succeded, so I guess the issue with the LIBS variable has something to do with my system?

@SethosII SethosII changed the title Add fastq-tools 0.8 for foss-2016b {bio}[foss/2016b] fastq-tools 0.8 Nov 24, 2017
@SethosII
Copy link
Copy Markdown
Contributor Author

@boegel Can you take a look at this pr? The LIBS problem is still there.

@boegel boegel added the new label Jun 28, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 28, 2018

@SethosII The problem is caused by the configure script not taking into account that $LIBS may be already defined in the environment; it's defined by EasyBuild as -lm -lpthread.

This seems to fix the issue:

preconfigopts = './autogen.sh && unset LIBS && '

@SethosII
Copy link
Copy Markdown
Contributor Author

@boegel Thanks! The configure template just adds -lm regardless of what LIBS is. I changed it in the easyconfig, so it works now.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 29, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in this PR)
node2598.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/bb819fc12b20c4202fbc1c6735c45267 for a full test report.

@boegel boegel added this to the 3.6.2 milestone Jun 29, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 29, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
gligar02.gligar.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/9107fedc92d98f6c6e4954cd875a7345 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 29, 2018

Going in, thanks @SethosII!

@boegel boegel merged commit 79bc1d2 into easybuilders:develop Jun 29, 2018
@SethosII SethosII deleted the fastq-tools branch June 29, 2018 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants