Skip to content

{chem}[intel/2017b] Multiwfn v3.4.1#5403

Merged
boegel merged 5 commits intoeasybuilders:developfrom
smoors:Multiwfn
Apr 24, 2018
Merged

{chem}[intel/2017b] Multiwfn v3.4.1#5403
boegel merged 5 commits intoeasybuilders:developfrom
smoors:Multiwfn

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Nov 23, 2017

The installation procedure is not ideal, but is justified by the limited number of users (currently).

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Feb 22, 2018

@wpoely86 review?

@easybuilders easybuilders deleted a comment from boegelbot Feb 22, 2018
@easybuilders easybuilders deleted a comment from boegelbot Feb 22, 2018
checksums = ['07141333f59a4bb3e3855a0c6c2ac61ae0aa9009bd40b375848ea2b641d4ab8f']

# The order of the source files is important!
# The source files are copied from the original Makefile
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors If there's a Makefile, why not use it? Maybe MakeCp is what you're after?

@boegel boegel added the new label Feb 22, 2018
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the 3.5.2 milestone Feb 27, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 27, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2689.swalot.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/ac5e9f63b4d94ec54a8da08c7ab20cc8 for a full test report.


prebuildopts = '/bin/bash noGUI.sh && cd noGUI && '

buildopts = 'OPT="-qopenmp" LIB="$LDFLAGS $LIBBLAS $LIBLAPACK" FC="$FC $FCFLAGS"'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors Hmm, prematurely approved... It's a better idea to use -fopenmp here, which works with both GCC and Intel compilers, otherwise this will be easily overlooked when changing the toolchain.

sources = ['%(name)s_%(version)s_src_Linux.zip']
checksums = ['07141333f59a4bb3e3855a0c6c2ac61ae0aa9009bd40b375848ea2b641d4ab8f']

prebuildopts = '/bin/bash noGUI.sh && cd noGUI && '
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason why you don't just use ./noGUI.sh here? Do you need to run this in a subshell?

If the script is missing the right permissions, you could do chmod u+x noGUI.sh && ./noGUI.sh?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The noGUI.sh script is executable but lacks a shebang. I just wanted to make sure it runs in bash.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention that in a comment above this line to clarify?

@boegel boegel modified the milestones: 3.5.2, 3.6.0 Feb 27, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 27, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2030.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/d12adc36a229e542b91dc45545730db1 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 24, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2038.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/a7793f73096b61ff9359f36aef73c3f9 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 24, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2480.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/8a078f4cd26371946382ad5450aebd3f for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 24, 2018

Going in, thanks @smoors!

@boegel boegel merged commit 32d0325 into easybuilders:develop Apr 24, 2018
@smoors smoors deleted the Multiwfn branch January 27, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants