Skip to content

{bio}[foss/2016b] FastQ_Screen 0.11.3 and 0.11.4#5404

Merged
boegel merged 6 commits intoeasybuilders:developfrom
SethosII:fastq_screen
Jan 9, 2018
Merged

{bio}[foss/2016b] FastQ_Screen 0.11.3 and 0.11.4#5404
boegel merged 6 commits intoeasybuilders:developfrom
SethosII:fastq_screen

Conversation

@SethosII
Copy link
Copy Markdown
Contributor

This adds FastQ_Screen.

It needs either of Bowtie, Bowtie2 or BWA to work. I mentioned this in the modloadmsg. Is this sufficient?

@SethosII
Copy link
Copy Markdown
Contributor Author

Also one question regarding the easyblock. Is PackedBinary the correct one here? There is also Tarball which seems to be very similar?

@SethosII
Copy link
Copy Markdown
Contributor Author

Version 0.11.4 was released a few days ago, so also adding an easyconfig for it.

@SethosII SethosII changed the title {bio}[foss/2016b] FastQ_Screen 0.11.3 {bio}[foss/2016b] FastQ_Screen 0.11.3 and 0.11.4 Nov 29, 2017
@boegel boegel added this to the 3.5.1 milestone Dec 27, 2017
@boegel boegel added the new label Dec 27, 2017
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 27, 2017

@SethosII I would say Tarball is more natural here, but in practice there's no difference here with PackedBinary.

Does FastQ Screen automatically pick Bowtie, Bowtie2 or BWA, or do you need to specify what it should use? Would it make sense to specify all three as dependencies?

@SethosII
Copy link
Copy Markdown
Contributor Author

SethosII commented Jan 2, 2018

@boegel I tried Tarball and the sanity check fails because it can't find the binary, so it seems Tarball doesn't set PATH (or at least not the same way as PackedBinary), should I switch to Tarball and modextrapaths = {'Path': ''}?

You have to specify what aligner should be used (-aligner bowtie|bowtie2|bwa). FastQ_Screen will complain if you miss the option. I have no opinion on whether we should include all aligners as dependencies.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 5, 2018

@SethosII That's right, when using Tarball you'll need to specify yourself that the programs are located in the top-level installation directory, using:

modextrapaths = {'PATH': ''}

Since you have to specify the aligner explicitly, I think it makes sense to include all three possible aligners as dependencies to FastQ_Screen and give the user full freedom?

@SethosII
Copy link
Copy Markdown
Contributor Author

SethosII commented Jan 8, 2018

@boegel I changed it to the Tarball easyblock and added all aligners as dependencies.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 9, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2066.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/1f5da8f7d19e0f8a5f38a803a4cf0923 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 9, 2018

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (2 easyconfigs in this PR)
node2406.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/dcb7eb200bd4f0bae70ea4b2de7c7eb4 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 9, 2018

Going in, thanks @SethosII!

@boegel boegel merged commit b400095 into easybuilders:develop Jan 9, 2018
@SethosII SethosII deleted the fastq_screen branch January 9, 2018 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants