Skip to content

New version of ASAP3, with OpenKIM support.#5479

Merged
boegel merged 2 commits intoeasybuilders:developfrom
schiotz:20171206142919_new_pr_ASAP33108
Dec 7, 2017
Merged

New version of ASAP3, with OpenKIM support.#5479
boegel merged 2 commits intoeasybuilders:developfrom
schiotz:20171206142919_new_pr_ASAP33108

Conversation

@schiotz
Copy link
Copy Markdown
Contributor

@schiotz schiotz commented Dec 6, 2017

(created using eb --new-pr)

@@ -0,0 +1,30 @@
name = 'OpenKIM-API'
version = '1.9.2'
easyblock = 'ConfigureMake'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schiotz Style remark: please put the easyblock line on top, include empty line below (for consistency with existing easyconfigs).


parallel = 1

modextrapaths = {'KIM_HOME': '.'}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just use empty string '' here rather than '.'

checksums = ['a167e89c717cc75c1ff41bb370b9454563c29333e49b7383e668094af547d139']

dependencies = [
('Python', '3.6.2'),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe go with the latest 3.6.3 here? Python easyconfig is already available.

@boegel boegel added this to the 3.5.0 milestone Dec 7, 2017
@schiotz
Copy link
Copy Markdown
Contributor Author

schiotz commented Dec 7, 2017

@boegel
Thanks for your suggestions.

I made the style change you suggested, and included an ASAP3 for the latest Python. That meant adding an ASE and matplotlib for that version, too.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 7, 2017

@schiotz Shall we remove the easyconfig using Python 3.6.2?

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 7, 2017

Test report by @boegel
SUCCESS
Build succeeded for 13 out of 13 (7 easyconfigs in this PR)
node2644.swalot.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/e213738b4061290480bdcb3ac2f885e8 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 7, 2017

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in this PR)
node2038.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/f790a50d66a01cd0a7ba9d7a0ca79a32 for a full test report.

@schiotz
Copy link
Copy Markdown
Contributor Author

schiotz commented Dec 7, 2017

Shall we remove the easyconfig using Python 3.6.2?

I do not have a strong preference, it is up to you. I left it on purpose, in case somebody has a cluster running Python 3.6.2 (just as ours is running 3.5.2 and may or may not be updated).

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 7, 2017

@schiotz OK, I see your point, let's leave it in then...

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 7, 2017

Going in, thanks @schiotz!

@boegel boegel merged commit 9402a23 into easybuilders:develop Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants