Skip to content

{bio}[foss/2016b] ChimPipe 0.9.5 + BEDTools 2.27.1#5560

Merged
boegel merged 4 commits intoeasybuilders:developfrom
SethosII:chimpipe
Jan 2, 2018
Merged

{bio}[foss/2016b] ChimPipe 0.9.5 + BEDTools 2.27.1#5560
boegel merged 4 commits intoeasybuilders:developfrom
SethosII:chimpipe

Conversation

@SethosII
Copy link
Copy Markdown
Contributor

@SethosII SethosII commented Dec 20, 2017

This adds ChimPipe with a updated BEDTools.

I can't think of a good sanity_check_commands line because printing the help message returns with non-zero exit code and a real example would need additional data.

@SethosII SethosII force-pushed the chimpipe branch 2 times, most recently from e48b6ef to 14c541c Compare December 20, 2017 10:34
@boegel boegel changed the base branch from master to develop December 23, 2017 20:16
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 23, 2017

@SethosII I had to change the target branch to develop (was master).

Since you have been issuing quite a lot of pull requests lately (thank you for that!), maybe you should take a look a the support EasyBuild has for creating pull requests via eb --new-pr, see http://easybuild.readthedocs.io/en/latest/Integration_with_GitHub.html.

Not only will it automatically take care of opening the PR to develop rather than master, it will also simplify things a bit for you.

toolchain = {'name': 'foss', 'version': '2016b'}

source_urls = ['https://github.com/arq5x/%(namelower)s2/releases/download/v%(version)s/']
sources = [SOURCELOWER_TGZ]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SethosII This should be SOURCELOWE_TAR_GZ instead?

Also, please include a SHA256 checksum.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel I changed this.


source_urls = ['https://github.com/Chimera-tools/%(name)s/archive']
sources = ['v%(version)s.tar.gz']

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style nitpicking: drop empty line

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel I changed this.


sanity_check_paths = {
'files': ['%(name)s.sh'],
'dirs': ['bin', 'src/awk', 'src/bash', 'tools'],
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific binaries you can check for?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel I added a specific binary and added a folder inside of bin.

@boegel boegel added this to the 3.5.1 milestone Dec 23, 2017
@SethosII
Copy link
Copy Markdown
Contributor Author

SethosII commented Jan 2, 2018

@boegel And thanks for the hint on eb --new-pr, I will take a look.

@boegel boegel changed the title {bio}[foss/2016b] ChimPipe 0.9.5 {bio}[foss/2016b] ChimPipe 0.9.5 + BEDTools 2.27.1 Jan 2, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 2, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2470.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/bd9eb2691582efeea74ffb182b2d6ccd for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 2, 2018

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in this PR)
node2129.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/771a584b4091128934055005dc5bf688 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 2, 2018

Going in, thanks @SethosII!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants