Skip to content

clean up BamTools easyconfigs to rely on updated easyblock + add SHA256 checksums#5575

Merged
verdurin merged 1 commit intoeasybuilders:developfrom
boegel:BamTools_cleanup
Jan 3, 2018
Merged

clean up BamTools easyconfigs to rely on updated easyblock + add SHA256 checksums#5575
verdurin merged 1 commit intoeasybuilders:developfrom
boegel:BamTools_cleanup

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 31, 2017 •
edited
Loading

files_to_copy was required, but not anymore thanks to updated BamTools easyblock in easybuilders/easybuild-easyblocks#1332

@boegel boegel added this to the 3.5.1 milestone Dec 31, 2017
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 31, 2017

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
gligar01.gligar.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/c71a89649d0b7289acc40fddd959f312 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 31, 2017

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node2663.swalot.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/bb18c1b0a2eb0d8c822aa698283ff9a8 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Jan 3, 2018
verdurin
verdurin reviewed Jan 3, 2018
View reviewed changes
Comment thread easybuild/easyconfigs/b/BamTools/BamTools-2.4.0-foss-2015b.eb
'files': ["bin/bamtools", "include/shared/bamtools_global.h", "lib/libbamtools.a",
"lib/libbamtools.so", "lib/libbamtools-utils.a", "lib/libjsoncpp.a"],
'dirs': ["include/api", "docs"]
}
Copy link
Copy Markdown
Member

@verdurin verdurin Jan 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel - is the sanity check removed because that's in the easyblock now?

Copy link
Copy Markdown
Member Author

@boegel boegel Jan 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@verdurin Yes, exactly (it actually already was, there was no reason at all to have it in the easyconfig file).

Copy link
Copy Markdown
Member

@verdurin verdurin Jan 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel - okay, thanks.

verdurin
verdurin approved these changes Jan 3, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine - I can't test all these toolchains.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 3, 2018

Going in, thanks @boegel!

@verdurin verdurin merged commit ac457c7 into easybuilders:develop Jan 3, 2018
@boegel boegel deleted the BamTools_cleanup branch January 3, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

Assignees

No one assigned

Labels

change enhancement

Projects

None yet

Milestone

3.5.1

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @verdurin