Skip to content

add missing libpng dependency in ROOT 6.10.08 easyconfigs#5595

Merged
verdurin merged 1 commit intoeasybuilders:developfrom
boegel:ROOT_libpng
Jan 5, 2018
Merged

add missing libpng dependency in ROOT 6.10.08 easyconfigs#5595
verdurin merged 1 commit intoeasybuilders:developfrom
boegel:ROOT_libpng

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jan 4, 2018

No description provided.

@boegel boegel added the bug fix label Jan 4, 2018
@boegel boegel added this to the 3.5.1 milestone Jan 4, 2018
@boegel boegel requested a review from verdurin January 4, 2018 18:11
@boegel boegel mentioned this pull request Jan 4, 2018
Merged
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 5, 2018

@boegel - change looks trivial. Could you submit some test runs?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 5, 2018

@verdurin I will, but since I'm making this change to try and fix the issue you ran into in #5524, maybe you should too? :)

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 5, 2018

@boegel - of course, but currently I don't have a single system that can build both those toolchains...

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 5, 2018

@verdurin Just testing one of them is fine imho (see http://easybuild.readthedocs.io/en/latest/Integration_with_GitHub.html#specifying-particular-easyconfig-files)

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 5, 2018

@boegel - nifty - didn't know that. foss version is building now.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 5, 2018

Test report by @verdurin
FAILED
Build succeeded for 6 out of 23 (2 easyconfigs in this PR)
dell.lan - Linux fedora 27, Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz, Python 2.7.14
See https://gist.github.com/39c42d81f8e3f01c5e1493649260ac2d for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 5, 2018

@verdurin You will need to make sure the necessary installation files for intel/2017b are available...

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 5, 2018

@boegel - yes, I know - that's the machine that doesn't have intel

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 5, 2018

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
rescomp2 - Linux centos 6.8, Intel(R) Xeon(R) CPU E5-2650 v2 @ 2.60GHz, Python 2.7.11
See https://gist.github.com/5f49b6a8a4c4c0c58b2ac7a11d67df4b for a full test report.

verdurin
verdurin approved these changes Jan 5, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 5, 2018

Going in, thanks @boegel!

@verdurin verdurin merged commit ef4c61d into easybuilders:develop Jan 5, 2018
@boegel boegel deleted the ROOT_libpng branch January 5, 2018 16:00
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 5, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2020.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/b82652351ae384a58e0d0bc5238a6f2a for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

3.5.1

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @verdurin