Skip to content

Patch binutils-2.26 for GCC-6.x compatibility#5611

Merged
boegel merged 3 commits intoeasybuilders:developfrom
vanzod:20180109101812_new_pr_binutils226
Jan 9, 2018
Merged

Patch binutils-2.26 for GCC-6.x compatibility#5611
boegel merged 3 commits intoeasybuilders:developfrom
vanzod:20180109101812_new_pr_binutils226

Conversation

@vanzod
Copy link
Copy Markdown
Member

@vanzod vanzod commented Jan 9, 2018

(created using eb --new-pr)

@@ -0,0 +1,29 @@
Add unused attribute to Dir_caches to avoid error with GCC 6 which treats warnings as errors. See https://sourceware.org/bugzilla/show_bug.cgi?format=multiple&id=19751
by Davide Vanzo (Vanderbilt University)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really by you, taken from upstream bug (see included URL), so just mention the URL?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the bug URL in the file. I had to modify the original patch because patching the changelog file failed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, makes sense, thanks for clarifying.

sources = [SOURCE_TAR_GZ]
source_urls = [GNU_SOURCE]
sources = [SOURCE_TAR_GZ]
patches = ['binutils-2.26_GCC-6.patch']
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make this 'binutils-%(version)s_GCC-6.patch'

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 9, 2018

@verdurin Can you give this a test on CentOS 6?

@boegel boegel added this to the 3.5.1 milestone Jan 9, 2018
@boegel boegel added the bug fix label Jan 9, 2018
@vanzod
Copy link
Copy Markdown
Member Author

vanzod commented Jan 9, 2018

Test report by @vanzod
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
cermis - Linux debian 9.3, Intel(R) Xeon(R) CPU E5620 @ 2.40GHz, Python 2.7.13
See https://gist.github.com/5b04eb8dd845448cab0413fc397418ca for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 9, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2066.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/268f53b80114ca58de81f0ea95b5c995 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 9, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2406.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/cd3ad315feca8a83262ae6533fb44db6 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 9, 2018

Test report by @verdurin
SUCCESS
Build succeeded for 0 out of 0 (1 easyconfigs in this PR)
rescomp2 - Linux centos 6.8, Intel(R) Xeon(R) CPU E5-2650 v2 @ 2.60GHz, Python 2.7.11
See https://gist.github.com/6912648a0e44f665cd5faca5bf5fe795 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 9, 2018

@verdurin Please test with --force? :)

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 9, 2018

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
rescomp2 - Linux centos 6.8, Intel(R) Xeon(R) CPU E5-2650 v2 @ 2.60GHz, Python 2.7.11
See https://gist.github.com/9df1f20d17db269f119521280ba9c552 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 9, 2018

Going in, thanks @vanzod!

@boegel boegel merged commit 6504dd4 into easybuilders:develop Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants