Skip to content

patch Hyperopt to make it work with networkx 2.0#5642

Merged
boegel merged 2 commits intoeasybuilders:developfrom
smoors:hyperopt
Feb 24, 2018
Merged

patch Hyperopt to make it work with networkx 2.0#5642
boegel merged 2 commits intoeasybuilders:developfrom
smoors:hyperopt

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Jan 16, 2018

No description provided.

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Feb 22, 2018

@wpoely86 review?

boegel
boegel requested changes Feb 22, 2018
View reviewed changes
Comment thread easybuild/easyconfigs/h/Hyperopt/Hyperopt-0.1-intel-2017b-Python-2.7.14.eb Outdated
source_urls = [PYPI_SOURCE]
sources = [SOURCELOWER_TAR_GZ]
checksums = ['4f6e903f7640165ea3e4c622050b41ffab0bee7811ede23c7825a5884976d72f']
patches = ['Hyperopt-0.1_networkx-2.0.patch']
Copy link
Copy Markdown
Member

@boegel boegel Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors Please avoid hardcoding the software version here if it matches: Hyperopt-%(version)s_networkx-2.0.patch (and drop the empty line below while you're at it)

@boegel boegel added this to the next release (3.5.2 or 3.6.0) milestone Feb 22, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 22, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2428.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/d86cb72cc9f3c048fba15af86b8e62e6 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 22, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
gligar03.gligar.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/de8de4aa64f28c6db417e6fb6adce366 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 24, 2018

Going in, thanks @smoors!

@boegel boegel merged commit 0b1961b into easybuilders:develop Feb 24, 2018
@smoors smoors deleted the hyperopt branch January 27, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix enhancement

Projects

None yet

Milestone

3.5.2

Development

Successfully merging this pull request may close these issues.

2 participants

@smoors @boegel