Skip to content

Config files for nano course#566

Merged
boegel merged 9 commits intoeasybuilders:developfrom
tovrstra:nanocourse
Dec 16, 2013
Merged

Config files for nano course#566
boegel merged 9 commits intoeasybuilders:developfrom
tovrstra:nanocourse

Conversation

@tovrstra
Copy link
Copy Markdown
Contributor

Several existing configs were copied and modified for the
combination ictce-4.1.13 and Python-2.7.3. The OpenBabel
package contains a Python extension, so they should get a
Python-2.7.X suffix. A Config for molden was added.

I'm not sure about one thing: the OpenBabel package installs a python extension in $PREFIX/lib (without python-2.7.X/site-packages) I hope this is OK. The PYTHONPATH variable is properly set in the module and when the module is loaded, I can indeed import the python extension.

Several existing configs were copied and modified for the
combination ictce-4.1.13 and Python-2.7.3. The OpenBabel
package contains a Python extension, so they should get a
Python-2.7.X suffix. A Config for molden was added.
@hpcugentbot
Copy link
Copy Markdown

Automatic reply from Jenkins: Can I test this?

@tovrstra
Copy link
Copy Markdown
Contributor Author

Yes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a names lawyer, yet I understand that the original developers refer to it as Molden,
hence first letter capitalized... wouldn't you prefer that one, then?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, no problem. I have indeed a personal bias toward lower case. The shift key is in my opinion one of the biggest mistakes in the history of IT. That said, I'm not going to try to convince the rest of the world. :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yeah, you do join the ranks of stdweird, then ;-)

IMHO, the whole capitals/spacing thingy is just adding redundant redundancy
in the language.
Pretty many ancient texts go fine about without it (OK, but you need double
time to read it then ;-)

From my P.o.V., we should write hex and be done with it all :-P

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, there's a tarball filename in here, that's redundant; also you could create one-liners if you prefer for single-list items
(sry I didn't notice earlier, I went through it in a very quick view).

As regards the patchfilenames, I think we have freedom there; anything goes, as long as people get to find their way...

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 10, 2013

Jenkins: ok to test

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 2.7.5, right? There's no such thing as Python 2.7.7 (yet).

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 11, 2013

@tovrstra: I'm working on a PR to your branch to fix the minor remarks I'm making in here. Just so you know...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use %(version)s

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 11, 2013

Remarks fixed in tovrstra#2

Thanks for the fixes. Looks good!
boegel added a commit that referenced this pull request Dec 16, 2013
Config files for nano course
@boegel boegel merged commit 7863f04 into easybuilders:develop Dec 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants