{math}[foss/2017b] HIPS v1.2b-rc5#5725
Conversation
|
@wpoely86 review? |
| prebuildopts += 'echo "AR = ar" >>makefile.inc && ' | ||
| prebuildopts += 'echo "ARFLAGS = -crs" >>makefile.inc && ' | ||
| prebuildopts += 'echo "LN = ln" >>makefile.inc && ' | ||
| prebuildopts += 'echo "CP = cp" >>makefile.inc && ' |
There was a problem hiding this comment.
Hmm, isn't it easier to just copy makefile.inc.gnu to makefile.inc via prebuildopts, and then override values via buildopts like this:
buildopts = 'ISCOTCH="-I$EBROOTSCOTCH/include" LSCOTCH="-L$EBROOTSCOTCH/lib -lscotch -lscotcherr" 'There was a problem hiding this comment.
cool, I did not know you can do that
| 'PARTITIONER=-DSCOTCH_PART ' | ||
| 'ISCOTCH="-I$EBROOTSCOTCH/include" ' | ||
| 'LSCOTCH="-L$EBROOTSCOTCH/lib -lscotch -lscotcherr" ' | ||
| 'all ' |
There was a problem hiding this comment.
@smoors We usually format multi-line buildopts like this (keeping related options together, use double quotes for all values for consistency):
buildopts = 'all LBLAS="$LIBBLAS" COEFTYPE="-DTYPE_REAL" PARTITIONER="-DSCOTCH_PART" '
buildopts += 'ISCOTCH="-I$EBROOTSCOTCH/include" LSCOTCH="-L$EBROOTSCOTCH/lib -lscotch -lscotcherr"'| 'all ' | ||
| ) | ||
|
|
||
| files_to_copy = [(['LIB/*'], 'lib')] |
There was a problem hiding this comment.
I also see *.h files being copied into lib, shouldn't we copy those to include instead (and adjust sanity_check_paths accordingly)?
files_to_copy = [
(['LIB/*.h', 'LIB/*.inc'], 'include'),
(['LIB/*.a'], 'lib'),
]
sanity_check_paths = {
'files': ['include/hips_fortran.h', 'include/hips.h', 'include/hips.inc', 'include/io.h', 'include/type.h',
'lib/libhips.a', 'lib/libhipssequential.a', 'lib/libio.a', 'lib/libspkit.a'],
'dirs': [],
}
|
Test report by @boegel |
|
Test report by @boegel |
|
Test report by @boegel |
|
Going in, thanks @smoors! |
No description provided.