Skip to content

{tools}[foss/2017b] udocker 1.1.1 w/ Python 2.7.14#5770

Merged
boegel merged 3 commits intoeasybuilders:developfrom
A1ve5:master
Apr 25, 2018
Merged

{tools}[foss/2017b] udocker 1.1.1 w/ Python 2.7.14#5770
boegel merged 3 commits intoeasybuilders:developfrom
A1ve5:master

Conversation

@A1ve5
Copy link
Copy Markdown
Contributor

@A1ve5 A1ve5 commented Feb 2, 2018

Still not working but a basis for an udocker easyconfig

dependencies = [
('Python', '2.7.14'),
]

Copy link
Copy Markdown
Contributor

@fgeorgatos fgeorgatos Mar 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to report that this easyconfig is about ready to work, modulo its sanitycheck; use via eb --from-pr 5770 -r;

I only had to resort to this trick to let it pass (I can feel the hot breath of @boegel on my neck over this hack :)

  • options = {'modulename': 'string'}

then we are able to obtain (@A1ve5 : could you implement that --version? it's a nice to have):

[fgeorgatos@somewhere ~]$ ml !$;!!
ml udocker;which udocker
~/.local/easybuild/software/udocker/1.1.1-foss-2017b-Python-2.7.14/bin/udocker
[fgeorgatos@somewhere ~]$ udocker --version
Error: parsing command line, use: udocker help

seriously, this requires minimal wrap-up effort to get it into next release... thanks @A1ve5

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this @fgeorgatos
On udocker we try to mimic docker command syntax, so "udocker version" should work.
Nevertheless I'll try to cover the "--version" option as well.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On devel branch now: indigo-dc/udocker@083b727

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fgeorgatos We're not savages, you can bypass the import check using this:

options = {'modulename': False}

;-)

@fgeorgatos
Copy link
Copy Markdown
Contributor

@boegel, @ALL:
can someone help @A1ve5 with the styling aspects? (I'm about out of tune with the process)

A1ve5 referenced this pull request in indigo-dc/udocker Mar 9, 2018
@boegel boegel changed the base branch from master to develop March 11, 2018 13:36
@boegel boegel changed the title initial easyconfig for udocker {tools}[foss/2017b] udocker 1.1.1 w/ Python 2.7.14 Mar 11, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 11, 2018

@A1ve5 @fgeorgatos Merging A1ve5#1 should make this good to go (installation works using that updated easyconfig).

For future PRs: please target the develop branch (or use eb --new-pr which will do this for you), I changed the target branch to develop myself for this PR.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 24, 2018

@A1ve5 ping on merging A1ve5#1 to make this ready to go?

@boegel boegel modified the milestones: 3.6.0, next release Apr 24, 2018
(style) fixes for udocker easyconfig file
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 25, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2644.swalot.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/5f26cbe6d6723e4a90077095cf1e6624 for a full test report.

@boegel boegel modified the milestones: next release, 3.6.0 Apr 25, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 25, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
gligar01.gligar.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/e515ab5b1037cc9ab61371bc0a87f26b for a full test report.

boegel added a commit to boegel/easybuild-easyconfigs that referenced this pull request Apr 25, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 25, 2018

Going in, thanks @A1ve5!

@boegel boegel merged commit dafc2d6 into easybuilders:develop Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants