Skip to content

binutils-2.26: Inhibit -Werror as new system GCC has case fallthrough warnings#5793

Merged
vanzod merged 2 commits intoeasybuilders:developfrom
zao:20180207220907_new_pr_binutils226
Oct 8, 2018
Merged

binutils-2.26: Inhibit -Werror as new system GCC has case fallthrough warnings#5793
vanzod merged 2 commits intoeasybuilders:developfrom
zao:20180207220907_new_pr_binutils226

Conversation

@zao
Copy link
Copy Markdown
Contributor

@zao zao commented Feb 7, 2018

(created using eb --new-pr)

@zao zao changed the title Inhibit -Werror as new system GCC has case fallthrough warnings binutils-2.26: Inhibit -Werror as new system GCC has case fallthrough warnings Feb 9, 2018
@boegel boegel added this to the 3.7.1 milestone Oct 8, 2018
@boegel boegel added the bug fix label Oct 8, 2018
boegel
boegel requested changes Oct 8, 2018
View reviewed changes
Comment thread easybuild/easyconfigs/b/binutils/binutils-2.26.eb
'1fd3088df8089d269c1e6ab74c5b4eb7793f9a321515ef96420f0d5ffef3fe75', # binutils-2.26_GCC-6.patch
]

configopts = ' --disable-werror'
Copy link
Copy Markdown
Member

@boegel boegel Oct 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zao Please add a comment to explain why this is there ;)

Copy link
Copy Markdown
Contributor Author

@zao zao Oct 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment added in next commit

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 8, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2070.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/2832703429e0141d52ed4cf5f4cc0bb0 for a full test report.

@zao
Update binutils-2.26.eb
9a6a992 
Motivate why warnings-as-errors are disabled for binutils
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 8, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2482.golett.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/7dd982443a9e2eab2a0a865c106ef9e4 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 8, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3107.skitty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/c15bd4602566140f806d1c6379814fac for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 8, 2018

Hmm, seems like the Travis notification to GitHub didn't pass through correctly, closing & re-opening to try and fix that...

@boegel boegel closed this Oct 8, 2018
@boegel boegel reopened this Oct 8, 2018
@murfreesboro
Copy link
Copy Markdown
Contributor

murfreesboro commented Oct 8, 2018

Test report by @murfreesboro
SUCCESS
Build succeeded for 0 out of 0 (1 easyconfigs in this PR)
phoenix - Linux ubuntu 16.04, Intel(R) Core(TM) i5-7300HQ CPU @ 2.50GHz, Python 2.7.12
See https://gist.github.com/3c02d509bf97048afccf1811356c3879 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 8, 2018

@murfreesboro Please use --force (and a temporary install location) when submitting test reports

@murfreesboro
Copy link
Copy Markdown
Contributor

murfreesboro commented Oct 8, 2018

Test report by @murfreesboro
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
phoenix - Linux ubuntu 16.04, Intel(R) Core(TM) i5-7300HQ CPU @ 2.50GHz, Python 2.7.12
See https://gist.github.com/95ebadafe9e82b23dd8ec4bbe6d57aa0 for a full test report.

@vanzod
Copy link
Copy Markdown
Member

vanzod commented Oct 8, 2018

Going in, thanks @zao!

@vanzod vanzod merged commit f127f62 into easybuilders:develop Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@vanzod vanzod vanzod approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

3.7.1

Development

Successfully merging this pull request may close these issues.

4 participants

@zao @boegel @murfreesboro @vanzod