Skip to content

{math}[foss/2017b] Ipopt 3.12.9#5800

Merged
boegel merged 4 commits intoeasybuilders:developfrom
smoors:ipopt
Feb 11, 2018
Merged

{math}[foss/2017b] Ipopt 3.12.9#5800
boegel merged 4 commits intoeasybuilders:developfrom
smoors:ipopt

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Feb 8, 2018

No description provided.

configopts += ' --with-asl-lib=-lasl --with-asl-incdir=$EBROOTAMPLMINMP/include/asl'

sanity_check_paths = {
'files': ['bin/ipopt', 'lib/libipopt.so'],
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't hardcode .so, use SHLIB_EXT instead please (.so is specific to Linux, we want to leave the door open for macOS too where a .so is a .dylib)

Maybe also check for libipoptamplinterface.so?

'files': ['bin/ipopt', 'lib/libipopt.%s' % SHLIB_EXT, 'lib/libipoptamplinterface.%s' % SHLIB_EXT],


sanity_check_paths = {
'files': ['bin/ipopt', 'lib/libipopt.so'],
'dirs': ['include/coin'],
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also check for lib/pkgconfig?

separate_build_dir = True

sanity_check_paths = {
'files': ['lib/libasl.a', 'lib/libmp.a'],
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not also check for lib/libbenchmark.a?

I would include checking for specific binaries here too:

sanity_check_paths = {
    'files': ['bin/tableproxy64', 'lib/libasl.a', 'lib/libbenchmark.a', 'lib/libmp.a'],
    'dirs': ['include/asl', 'include/benchmark', 'include/mp', 'share'],
}

@boegel boegel added this to the next release (3.5.2 or 3.6.0) milestone Feb 9, 2018
@boegel boegel added the new label Feb 9, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 10, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
gligar01.gligar.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/3789b8e75f754f359e22115646e0a13a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 10, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2310.phanpy.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/e162589d63331cb4be2213b55eb966a5 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 11, 2018

Going in, thanks @smoors!

@boegel boegel merged commit bde00fb into easybuilders:develop Feb 11, 2018
@smoors smoors deleted the ipopt branch January 27, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants