Skip to content

{bio}[foss/2016a,foss/2016b,foss/2017a] fastStructure v1.0, fastStructure v1.0, fastStructure v1.0#5866

Merged
migueldiascosta merged 6 commits intoeasybuilders:developfrom
Gregor-Mendel-Institute:20180221131809_new_pr_fastStructure10
Oct 3, 2019
Merged

{bio}[foss/2016a,foss/2016b,foss/2017a] fastStructure v1.0, fastStructure v1.0, fastStructure v1.0#5866
migueldiascosta merged 6 commits intoeasybuilders:developfrom
Gregor-Mendel-Institute:20180221131809_new_pr_fastStructure10

Conversation

@timeu
Copy link
Copy Markdown
Contributor

@timeu timeu commented Feb 21, 2018

(created using eb --new-pr)

easybuild@GMI added 3 commits February 21, 2018 13:18
adding easyconfigs: fastStructure-1.0-foss-2016a-Python-2.7.11.eb, fa…
817205e 
…stStructure-1.0-foss-2016b-Python-2.7.12.eb, fastStructure-1.0-foss-2017a-Python-2.7.13.eb
Added patch to make sure that command line scripts are executable and…
2eb42ba 
… fixes for setup.py
Added checksums
26f736a
@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Feb 15, 2019

@timeu there's now a fastStructure easyblock (easybuilders/easybuild-easyblocks#1529), do you want to update this PR accordingly? (see #6893)

migueldiascosta
migueldiascosta requested changes Oct 2, 2019
View reviewed changes
Comment thread easybuild/easyconfigs/f/fastStructure/fastStructure-1.0-foss-2016b-Python-2.7.12.eb Outdated
@migueldiascosta migueldiascosta added this to the next release (4.0.1) milestone Oct 2, 2019
@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Oct 2, 2019

Test report by @migueldiascosta
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
grc-cluster1 - Linux centos 6.10, Intel(R) Xeon(R) CPU E5-2640 0 @ 2.50GHz, Python 2.7.14
See https://gist.github.com/174ff2195afeef84faa0b776445046f1 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 2, 2019

Travis test report: 5/5 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/592444042

Only showing partial log for 1st failed test suite run 17362.1;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/592444043

...
FAIL: Specific checks only done for the (easyconfig) files that were changed in a pull request.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 535, in test_changed_files_pull_request
    self.check_https(changed_ecs)
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 479, in check_https
    self.assertFalse(failing_checks, '\n'.join(failing_checks))
AssertionError: Found http:// URL in fastStructure-1.0-foss-2016b-Python-2.7.12.eb, should be https:// : http://rajanil.github.io/fastStructure/
Found http:// URL in fastStructure-1.0-foss-2017a-Python-2.7.13.eb, should be https:// : http://rajanil.github.io/fastStructure/

----------------------------------------------------------------------
Ran 8411 tests in 740.313s

FAILED (failures=1)
ERROR: Not all tests were successful.

*bleep, bloop, I'm just a bot (boegelbot v20180813.01)*Please talk to my owner @boegel if you notice you me acting stupid),or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Oct 3, 2019

Going in, thanks @timeu!

@migueldiascosta migueldiascosta merged commit 0af7a96 into easybuilders:develop Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees

No one assigned

Labels

update

Projects

None yet

Milestone

4.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@timeu @migueldiascosta @boegelbot