Skip to content

{bio}[foss/2016a] GAT v1.2.2#5871

Merged
migueldiascosta merged 4 commits intoeasybuilders:developfrom
Gregor-Mendel-Institute:20180221150028_new_pr_GAT122
Oct 3, 2019
Merged

{bio}[foss/2016a] GAT v1.2.2#5871
migueldiascosta merged 4 commits intoeasybuilders:developfrom
Gregor-Mendel-Institute:20180221150028_new_pr_GAT122

Conversation

@timeu
Copy link
Copy Markdown
Contributor

@timeu timeu commented Feb 21, 2018

(created using eb --new-pr)

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Feb 15, 2019

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
grc-cluster1 - Linux centos 6.10, Intel(R) Xeon(R) CPU E5-2640 0 @ 2.50GHz, Python 2.7.14
See https://gist.github.com/e1e456194709db51fc01ea4f690cc741 for a full test report.

@migueldiascosta migueldiascosta added this to the 3.x milestone Feb 15, 2019
@timeu
Copy link
Copy Markdown
Contributor Author

timeu commented Oct 1, 2019

Ping ?

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Oct 2, 2019

@timeu, this PR is being closed for the following reason(s): closing and reopening to trigger tests.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 2, 2019

Travis test report: 5/5 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/592351615

Only showing partial log for 1st failed test suite run 17338.1;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/592351616

...
FAIL: Specific checks only done for the (easyconfig) files that were changed in a pull request.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 533, in test_changed_files_pull_request
    self.check_python_packages(changed_ecs)
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 433, in check_python_packages
    self.assertFalse(failing_checks, '\n'.join(failing_checks))
AssertionError: 'download_dep_fail' set in GAT-1.2.2-foss-2016a-Python-2.7.11.eb
'use_pip' set in GAT-1.2.2-foss-2016a-Python-2.7.11.eb

----------------------------------------------------------------------
Ran 8407 tests in 772.868s

FAILED (failures=1)
ERROR: Not all tests were successful.

*bleep, bloop, I'm just a bot (boegelbot v20180813.01)*Please talk to my owner @boegel if you notice you me acting stupid),or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 2, 2019

Travis test report: 5/5 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/592444904

Only showing partial log for 1st failed test suite run 17363.1;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/592444905

...
FAIL: Specific checks only done for the (easyconfig) files that were changed in a pull request.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 535, in test_changed_files_pull_request
    self.check_https(changed_ecs)
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 479, in check_https
    self.assertFalse(failing_checks, '\n'.join(failing_checks))
AssertionError: Found http:// URL in GAT-1.2.2-foss-2016a-Python-2.7.11.eb, should be https:// : http://gat.readthedocs.io/

----------------------------------------------------------------------
Ran 8410 tests in 773.574s

FAILED (failures=1)
ERROR: Not all tests were successful.

*bleep, bloop, I'm just a bot (boegelbot v20180813.01)*Please talk to my owner @boegel if you notice you me acting stupid),or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

migueldiascosta
migueldiascosta approved these changes Oct 3, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Oct 3, 2019

Going in, thanks @timeu!

@migueldiascosta migueldiascosta merged commit ba6cedd into easybuilders:develop Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@timeu @migueldiascosta @boegelbot