Skip to content

{bio}[foss/2017a] methylpy v1.1.9, cutadapt v1.14, SAMtools v1.6#5874

Merged
boegel merged 2 commits intoeasybuilders:developfrom
Gregor-Mendel-Institute:20180221153602_new_pr_methylpy119
Feb 25, 2018
Merged

{bio}[foss/2017a] methylpy v1.1.9, cutadapt v1.14, SAMtools v1.6#5874
boegel merged 2 commits intoeasybuilders:developfrom
Gregor-Mendel-Institute:20180221153602_new_pr_methylpy119

Conversation

@timeu
Copy link
Copy Markdown
Contributor

@timeu timeu commented Feb 21, 2018

(created using eb --new-pr)

adding easyconfigs: methylpy-1.1.9-foss-2017a-Python-2.7.13.eb, cutad…
f53dbc6 
…apt-1.14-foss-2017a-Python-2.7.13.eb, SAMtools-1.6-foss-2017a.eb
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Feb 22, 2018

Test report by @verdurin
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
admin3.novalocal - Linux centos linux 7.4.1708, Intel Xeon E312xx (Sandy Bridge), Python 2.7.5
See https://gist.github.com/2b0fba445a86908ba878543434e4b924 for a full test report.

verdurin
verdurin previously requested changes Feb 22, 2018
View reviewed changes
Comment thread easybuild/easyconfigs/m/methylpy/methylpy-1.1.9-foss-2017a-Python-2.7.13.eb
toolchain = {'name': 'foss', 'version': '2017a'}

source_urls = ['https://github.com/yupenghe/methylpy/archive/']
sources = ['%(version)s.tar.gz']
Copy link
Copy Markdown
Member

@verdurin verdurin Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timeu please add a checksum here with --inject-checksums

@verdurin verdurin added this to the next release (3.5.2 or 3.6.0) milestone Feb 22, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 25, 2018

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
gligar01.gligar.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/ef5636b43da68519af94deb566dba4a9 for a full test report.

@boegel boegel dismissed verdurin’s stale review February 25, 2018 11:23

missing checksums were added

boegel
boegel approved these changes Feb 25, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 25, 2018

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (3 easyconfigs in this PR)
node2411.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/dc7911872e913a691fab05c812dfda8b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 25, 2018

Going in, thanks @timeu!

@boegel boegel merged commit 878f076 into easybuilders:develop Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@verdurin verdurin verdurin left review comments

Assignees

No one assigned

Labels

update

Projects

None yet

Milestone

3.5.2

Development

Successfully merging this pull request may close these issues.

3 participants

@timeu @verdurin @boegel