Add Tkinter sanity check to ASE (intel toolchain, take 2).#5909
Add Tkinter sanity check to ASE (intel toolchain, take 2).#5909boegel merged 2 commits intoeasybuilders:developfrom
Conversation
|
@schiotz Don't worry about ruining the other PR, it happens. Is there anything we can improve to |
|
Test report by @boegel |
|
Test report by @boegel edit: failed due to changes to |
| } | ||
|
|
||
| # make sure Tkinter is available, otherwise 'ase gui' will not work | ||
| sanity_check_commands = ["python -c 'import tkinter' "] |
There was a problem hiding this comment.
@schiotz Typo here, should be import Tkinter (capital T)
|
@boegel Sorry about the typo - that is the danger of submitting PRs to toolchains one cannot use. :-)
I would not worry about adding this to eb. It is unavoidable that PRs get out of sync with the develop branch, and that may involve conflicts and all kinds of mess. Once you are in that situation, it would be difficult to fix through eb's interface, and would require interfacing to (or duplicating) much of the logic in git. One can always either open a new PR, or use git in the relevant branch. If that is too complicated, then doing the same through eb is not going to be easier. |
|
Test report by @boegel |
|
Test report by @boegel |
|
Test report by @boegel |
|
Going in, thanks @schiotz! |
(created using
eb --new-pr)This PR is supposed to replace PR #5692 which failed its selftest due to a broken Tkinter config. As @boegel had already merged a correct version of this file, I tried to remove it but managed to completely mess up the PR with
eb --update-pr. I could not recover, and made this replacement. Sorry about the mess, this will require @boegel to review it again. :-(