Skip to content

Only SAMtools < 1.0 works for ChimPipe#5930

Merged
boegel merged 2 commits intoeasybuilders:developfrom
SethosII:20180228132600_new_pr_ChimPipe095
Jul 6, 2018
Merged

Only SAMtools < 1.0 works for ChimPipe#5930
boegel merged 2 commits intoeasybuilders:developfrom
SethosII:20180228132600_new_pr_ChimPipe095

Conversation

@SethosII
Copy link
Copy Markdown
Contributor

@SethosII SethosII commented Feb 28, 2018

(created using eb --new-pr)

The options of SAMtools sort subcommand have changed in 1.0 and ChimPipe still uses the old options.

@verdurin
Copy link
Copy Markdown
Member

@SethosII Would be useful to add a comment explaining this change of dependencies in the easyconfig itself?

@verdurin
Copy link
Copy Markdown
Member

Test report by @verdurin
FAILED
Build succeeded for 19 out of 24 (1 easyconfigs in this PR)
easybuild.novalocal - Linux centos linux 7.4.1708, Intel Xeon E312xx (Sandy Bridge), Python 2.7.5
See https://gist.github.com/736dc55c7cd345b8a47c5ae86b8b6537 for a full test report.

@SethosII
Copy link
Copy Markdown
Contributor Author

SethosII commented Mar 16, 2018

@verdurin The reason for the build error seems to be missing X header files?

And eb --update-pr is stuck on my terminal but pushed successfully and garbled the author. Seems to be related to easybuilders/easybuild-framework#2415.

@SethosII SethosII force-pushed the 20180228132600_new_pr_ChimPipe095 branch from eadee0a to d735dc8 Compare June 29, 2018 07:29
@SethosII
Copy link
Copy Markdown
Contributor Author

I force-pushed the commit with the correct author.

@boegel boegel added this to the 3.6.2 milestone Jul 6, 2018
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Only SAMtools < 1.0 works Only SAMtools < 1.0 works for ChimPipe Jul 6, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 6, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
gligar02.gligar.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/9dab3da793da6e7f87b88904d126f051 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 6, 2018

Going in, thanks @SethosII!

@boegel boegel merged commit 50b1765 into easybuilders:develop Jul 6, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 6, 2018

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (1 easyconfigs in this PR)
node2524.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/837cb023a50709a0c1c92e6ddf22b84c for a full test report.

@SethosII SethosII deleted the 20180228132600_new_pr_ChimPipe095 branch July 6, 2018 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants