Skip to content

fix installation of TensorFlow 1.3 via binary wheel after introducing TensorFlow easyblock#5938

Merged
verdurin merged 4 commits intoeasybuilders:3.5.xfrom
boegel:fix_TF1.3
Mar 1, 2018
Merged

fix installation of TensorFlow 1.3 via binary wheel after introducing TensorFlow easyblock#5938
verdurin merged 4 commits intoeasybuilders:3.5.xfrom
boegel:fix_TF1.3

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 1, 2018

Workaround for framework issue easybuilders/easybuild-framework#2417, this only started occurring after the custom easyblock for TensorFlow was added in easybuilders/easybuild-easyblocks#1287.

Changing the extension name to tensorflow rather than TensorFlow makes the import of the class from tensorflow.py fail (because there's no EB_tensorflow class, only EB_TensorFlow).

Since tensorflow is also used as extension name in older TensorFlow easyconfigs (v1.2.x) I feel this is an acceptable workaround for now...

@boegel boegel added the bug fix label Mar 1, 2018
@boegel boegel added this to the 3.5.2 milestone Mar 1, 2018
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 1, 2018

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
gligar03.gligar.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/ea0b0e4d1b203717a22f046e1510d9f1 for a full test report.

@boegel boegel changed the base branch from develop to 3.5.x March 1, 2018 16:11
@verdurin verdurin merged commit 23f9465 into easybuilders:3.5.x Mar 1, 2018
@boegel boegel deleted the fix_TF1.3 branch March 1, 2018 17:38
boegel added a commit to boegel/easybuild-easyconfigs that referenced this pull request Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants