{bio}[intel/2018a] MAJIQ v1.1.1, Pysam v0.14 w/ Python 3.6.4 (REVIEW)#5983
Conversation
…ions to fix name of top-level source dir
|
Test report by @boegel |
|
Test report by @vanzod |
|
|
|
|
||
| builddependencies = [ | ||
| # older version of Cython required to work around "AttributeError: ... has no attribute '__reduce_cython__' | ||
| # see https://github.com/cython/cython/issues/1953 |
There was a problem hiding this comment.
Unless I am misinterpreting this comment (in which case it should be rephrased), since python-3.6.4-intel-2018a comes bundled with Cython-0.27.3, there should be no need to carry over the older version of Cython as builddependency.
Can you clarify this?
There was a problem hiding this comment.
0.27.3 is too new, 0.25.2 doesn't have the issue
There was a problem hiding this comment.
Maybe add another comment line just to make it a little more explicit?
There was a problem hiding this comment.
Or, even better in my opinion, adding it to the MAJIQ bundle so that there is less risk of user conflict with the one bundled with Python?
There was a problem hiding this comment.
Moving it into the bundle makes it a runtime dependency, which it's not...
I'll clarify the comment.
|
Test report by @vanzod |
|
@vanzod Please check whether the enhanced Like so:
|
|
Test report by @vanzod |
|
Going in, thanks @boegel! |
(created using
eb --new-pr)requires
easybuilders/easybuild-easyblocks#1384, depends on#5976(matplotlib) +#5977(h5py)edit: requires
easybuilders/easybuild-easyblocks#1391