Skip to content

{bio} [foss/2016b] Porechop 0.2.3 w/ Python 3.5.2#6051

Merged
boegel merged 7 commits intoeasybuilders:developfrom
pescobar:porechop
Mar 22, 2018
Merged

{bio} [foss/2016b] Porechop 0.2.3 w/ Python 3.5.2#6051
boegel merged 7 commits intoeasybuilders:developfrom
pescobar:porechop

Conversation

@pescobar
Copy link
Copy Markdown
Member

@pescobar pescobar commented Mar 20, 2018

No description provided.

boegel
boegel requested changes Mar 21, 2018
View reviewed changes
Comment thread easybuild/easyconfigs/p/Porechop/Porechop-0.2.3-foss-2016b-Python-3.5.2.eb Outdated

sanity_check_paths = {
'files': ['bin/porechop', 'lib/python%(pyshortver)s/site-packages/porechop/porechop.py'],
'dirs': ['lib/python%(pyshortver)s/site-packages/porechop-%(version)s-py%(pyshortver)s.egg-info']
Copy link
Copy Markdown
Member

@boegel boegel Mar 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pescobar We usually just check for a non-empty 'lib/python%(pyshortver)s/site-packages' dir, since the .egg stuff may be either a file or a directory, depends on the context...

@boegel boegel added this to the 3.6.0 milestone Mar 21, 2018
@boegel boegel added the new label Mar 21, 2018
@boegel boegel changed the title {bio} [foss/2016b] Porechop 0.2.3 {bio} [foss/2016b] Porechop 0.2.3 w/ Python 3.5.2 Mar 21, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 21, 2018

@pescobar Needs a sync with develop now that #5785 is merged...

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 21, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2081.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/33709a117cf05440ef1973ee73905de3 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 21, 2018

Test report by @boegel
SUCCESS
Build succeeded for 12 out of 12 (1 easyconfigs in this PR)
node2631.swalot.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/4adc89e4b609a4b7f042446466b4d2d0 for a full test report.

@pescobar
Copy link
Copy Markdown
Member Author

pescobar commented Mar 21, 2018

@boegel I have synced with develop

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 22, 2018

Going in, thanks @pescobar!

@boegel boegel merged commit 3c7d9ec into easybuilders:develop Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@pescobar @boegel