Skip to content

drop use of --disable-dlopen in (recent) OpenMPI easyconfigs due to negative performance impact#6060

Merged
vanzod merged 1 commit intoeasybuilders:developfrom
boegel:openmpi_remove_disable_dlopen
Mar 22, 2018
Merged

drop use of --disable-dlopen in (recent) OpenMPI easyconfigs due to negative performance impact#6060
vanzod merged 1 commit intoeasybuilders:developfrom
boegel:openmpi_remove_disable_dlopen

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 22, 2018

cfr. #5716

The use of --disable-dlopen was originally introduced in #186 to fix a problem with Rmpi (see also https://www.mail-archive.com/[email protected]/msg10852.html).

I retested the installation of Rmpi on top of both foss/2017b and foss/2016a after rebuilding the OpenMPI component of those toolchains without --disable-dlopen, and I could not reproduce the Rmpi problem, so it seems like our original motivation for including --disable-dlopen is no longer valid anyway...

cc @m0zes, @chrissamuel, @akesandgren

Copy link
Copy Markdown
Member

@pescobar pescobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 22, 2018

Test report by @boegel
SUCCESS
Build succeeded for 22 out of 22 (22 easyconfigs in this PR)
node2653.swalot.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/c07d538f2a333060eb8138d94cd4f841 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 22, 2018

Test report by @boegel
SUCCESS
Build succeeded for 18 out of 18 (18 easyconfigs in this PR)
node2106.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/f448e7aedb75344458ffec82b54c83bf for a full test report.

@vanzod
Copy link
Copy Markdown
Member

vanzod commented Mar 22, 2018

Going in, thanks @boegel!

@vanzod vanzod merged commit 003fe14 into easybuilders:develop Mar 22, 2018
@boegel boegel deleted the openmpi_remove_disable_dlopen branch March 22, 2018 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants