add patch for Tensorflow 1.6 & 1.7 to include missing -lrt link flag (needed in CentOS6)#6089
Conversation
|
@Micket Just adding the patch without using it in any of the easyconfigs is a bit confusing... Does including this patch on CentOS 7 or other operating systems cause problems? If not, we should always use it? |
|
@boegel Sorry, I was going to comment it, but --new-pr took quite a long time, and I forgot about this. The patch is something I needed to use with Tensorflow in order to built it on CentOS6, because of a link-flag that doesn't get propagated. I can't imagine it hurting compilation on any other system, because it will be linking to this library anyway. I got the fix from: Though, on CenOS6, I still need to modify the original configs with_jemalloc=False (or some other workaround, due to the old kernel). |
|
@Micket Can you update this PR to use this patch in the TensorFlow 1.6.0 easyconfigs we have, so we can easily test it on other OSs? If it doesn't cause problems there, I would include it, one less problem to worry about on CentOS 6... |
|
Test report by @boegel |
|
@vanzod Up for testing this to make sure the patch doesn't cause any trouble on other OSs? |
|
@Micket Any idea if this is relevant when building with Intel compilers? Did you try that? |
|
@boegel I think it would apply there as well, but I haven't tested. I'll give it a try |
|
@boegel intel/2018a requires us to first update the license server to 11.14, which it refused to do on our virtual machines due to the cpu model number 😲 |
|
@Micket Can you sync with PR with current |
|
Test report by @boegel |
|
Test report by @boegel |
b4d0bf3 to
8130848
Compare
|
@boegel Done, should be ready for another test build for 1.7.0 |
|
Test report by @boegel |
8130848 to
4ac8b8d
Compare
|
I've tested this outside of this PR after merging this branch with current Thanks @Micket! |
(created using
eb --new-pr)