Skip to content

{vis}[foss/2018a] SimpleElastix v0.10.0#6114

Merged
boegel merged 5 commits intoeasybuilders:developfrom
smoors:20180404164938_new_pr_SimpleElastix0100
Apr 29, 2018
Merged

{vis}[foss/2018a] SimpleElastix v0.10.0#6114
boegel merged 5 commits intoeasybuilders:developfrom
smoors:20180404164938_new_pr_SimpleElastix0100

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Apr 4, 2018

(created using eb --new-pr)

adding easyconfigs: SimpleElastix-0.10.0-foss-2018a-Python-3.6.4.eb a…
847f4b0 
…nd patches: SimpleElastix-0.10.0_git-version.patch
@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Apr 6, 2018

please don't merge this yet, there are some issues.

@boegel boegel changed the title {vis}[foss/2018a] SimpleElastix v0.10.0 {vis}[foss/2018a] SimpleElastix v0.10.0 (WIP) Apr 7, 2018
@boegel boegel added the new label Apr 7, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 7, 2018

@smoors Marked as WIP, let us know if you figure out the problems you're seeing

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Apr 17, 2018

it turned out to be a user error.
SimpleElastix also compiles elastix, ITK, and SimpleITK, so I guess it makes sense to make the binaries available.

@smoors smoors changed the title {vis}[foss/2018a] SimpleElastix v0.10.0 (WIP) {vis}[foss/2018a] SimpleElastix v0.10.0 Apr 17, 2018
@easybuilders easybuilders deleted a comment from boegelbot Apr 18, 2018
boegel
boegel requested changes Apr 18, 2018
View reviewed changes
Comment thread easybuild/easyconfigs/s/SimpleElastix/SimpleElastix-0.10.0-foss-2018a-Python-3.6.4.eb Outdated

source_urls = ['https://github.com/SuperElastix/SimpleElastix/archive/']
sources = ['v%(version)s.tar.gz']
patches = ['SimpleElastix-0.10.0_git-version.patch']
Copy link
Copy Markdown
Member

@boegel boegel Apr 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors Please use %(version)s rather than hardcoding the version

Comment thread easybuild/easyconfigs/s/SimpleElastix/SimpleElastix-0.10.0-foss-2018a-Python-3.6.4.eb Outdated

sanity_check_paths = {
'files': [],
'dirs': ['include/SimpleITK-0.10', 'lib', 'share']
Copy link
Copy Markdown
Member

@boegel boegel Apr 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors please use %(version_major_minor)s rather than hardcoding 0.10

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 18, 2018

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
gligar01.gligar.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/a937713f27ea821fecaf1b2cff2d417b for a full test report.

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Apr 18, 2018

@boegel this is probably a memory issue, as simpleelastix requires about 4gb of memory per core.
Can you please retry with more memory?

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 18, 2018

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
node2546.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/ef2b1f2ed8cab693a4ed8fd14d43728e for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 18, 2018

@smoors missing deps (Java, Tcl, Tk):

-- Found Java: /usr/bin/java (found version "1.8.0.161") found components:  Development Runtime 
-- Found JNI: /usr/lib/jvm/jre/lib/amd64/libjawt.so  
-- Found Tclsh: /bin/tclsh (found version "8.5") 
-- Found TCL: /usr/lib64/libtcl.so  
CMake Error at /user/scratchphanpy/gent/gvo000/gvo00002/vsc40023/easybuild_REGTEST/CO7/haswell-ib/software/CMake/3.10.2-GCCcore-6.4.0/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
Could NOT find TCLTK (missing: TK_INCLUDE_PATH)

@boegel boegel added this to the 3.6.1 milestone Apr 29, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 29, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2516.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/1edd53b9128bb2bf45180176eae7013a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 29, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2125.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/904df283d0a72e5c86be87bad236d414 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 29, 2018

Going in, thanks @smoors!

@boegel boegel merged commit 3c45f83 into easybuilders:develop Apr 29, 2018
@smoors smoors deleted the 20180404164938_new_pr_SimpleElastix0100 branch January 27, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

3.6.1

Development

Successfully merging this pull request may close these issues.

2 participants

@smoors @boegel