{bio}[foss/2016b] ARAGORN 1.2.38#6138
Merged
verdurin merged 1 commit intoeasybuilders:developfrom Apr 20, 2018
Merged
Conversation
Member
|
Test report by @verdurin |
verdurin
reviewed
Apr 18, 2018
|
|
||
| cmds_map = [ | ||
| (".*", "$CC $CFLAG -O3 -ffast-math -finline-functions -o aragorn aragorn%(version)s.c") | ||
| ] |
Member
Author
There was a problem hiding this comment.
@verdurin the tarball only includes a .c file and a man page file. I followed the build instructions from their website
http://mbio-serv2.mbioekol.lu.se/ARAGORN/Downloads/
Member
|
Going in, thanks @pescobar! |
boegel
reviewed
Apr 20, 2018
| checksums = ['4b84e3397755fb22cc931c0e7b9d50eaba2a680df854d7a35db46a13cecb2126'] | ||
|
|
||
| cmds_map = [ | ||
| (".*", "$CC $CFLAG -O3 -ffast-math -finline-functions -o aragorn aragorn%(version)s.c") |
Member
There was a problem hiding this comment.
@pescobar This should be using $CC $CFLAGS -o aragorn aragorn%(version)s.c imho...
I.e. don't hardcode -O3 or other options related to code performance, and use $CFLAGS (not $CFLAG)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.