{tools}[foss/2018a] SimpleITK 1.1.0 w/Python-3.6.4 (REVIEW)#6172
{tools}[foss/2018a] SimpleITK 1.1.0 w/Python-3.6.4 (REVIEW)#6172boegel merged 2 commits intoeasybuilders:developfrom
Conversation
| @@ -0,0 +1,20 @@ | |||
| easyblock = "Tarball" | |||
|
|
|||
| name = 'gtest' | |||
There was a problem hiding this comment.
@hajgato Why does this also include gtest, not a dep?
There was a problem hiding this comment.
@boegel First I thought that gtest is a dep, but it is only needed if you run the tests. By default, tests are not run, so I removed the gtest dep. Once I made the EasyConfig, I did not want to waste it. If its not a big problem, then I would not make a separate PR for it.
There was a problem hiding this comment.
OK, it's fine to leave it there, I thought it got included by accident.
| modextrapaths = {'PYTHONPATH': ['lib/python%(pyshortver)s/site-packages']} | ||
|
|
||
| sanity_check_paths = { | ||
| 'files': ['lib/libSimpleITKExplicit-1.1.a'], |
There was a problem hiding this comment.
@hajgato Please use %(version_major_minor)s rather than hardcoding 1.1?
|
Test report by @boegel |
|
@boegel comments fixed + TCL fixed (hopefully) |
|
continous-integration/travis-ci/pr |
|
@boegel Can we retrigger travis-ci? |
|
@hajgato Done. Note that you can do this yourself by closing and re-opening the PR (which is the officially supported way according to Travis support...) |
|
Test report by @boegel |
|
Test report by @boegel |
|
Going in, thanks @hajgato! |
|
Test report by @boegel |
No description provided.