{bio}[foss/2017a] HOME v0.9#6227
Conversation
boegel
left a comment
There was a problem hiding this comment.
side-note: worst software name ever >_<
| + 'pandas', | ||
| + 'scipy', | ||
| 'scikit-learn==0.16.1', | ||
| 'statsmodels==0.6.1', |
There was a problem hiding this comment.
@timeu Why not do the same for scikit-learn and statsmodels, there's little point in fixing those version that hard I think?
| @@ -0,0 +1,14 @@ | |||
| diff -ru HOME-0.9/setup.py HOME-0.9.modified/setup.py | |||
There was a problem hiding this comment.
@timeu Please include a short description of the patch + mention author or upstream reference (and then fix the SHA256 checksum accordingly)
| 'checksums': ['4313dd4cbf1ebadef3661f6efd895132b615016e9bee560b5fdfd80c74dd422f'], | ||
| }), | ||
| ] | ||
|
|
There was a problem hiding this comment.
@timeu One of the existing statsmodels easyconfigs has this, should be included here too:
# specify that Bundle easyblock should run a full sanity check, rather than just trying to load the module
full_sanity_check = True
| ('statsmodels', '0.6.1', versionsuffix) | ||
| ] | ||
|
|
||
|
|
There was a problem hiding this comment.
@timeu please avoid duplicate empty lines, one is enough
| 'dirs': ['lib/python%(pyshortver)s/site-packages'], | ||
| } | ||
|
|
||
|
|
| sources = ['%(version)s.tar.gz'] | ||
| patches = ['HOME-%(version)s_setup.patch'] | ||
| checksums = [ | ||
| '6cb75a2f1fa22cd1f979fcbbaf4b7c2b1e932a6aad0b332a64013be335906266', # 0.9.tar.gz |
There was a problem hiding this comment.
I'm getting a different check here btw (fresh download): bca765e8eb86878f1798e44b313ee8d9670e0dceed7c8be2eec72991ce22041a
There was a problem hiding this comment.
Hmm yes me too, but for some reason --inject-checksums always returns me this checksum:
== temporary log file in case of crash /tmp/eb-EOFgJ6/easybuild-crdcEt.log
== injecting sha256 checksums in /net/gmi.oeaw.ac.at/software/mendel/easybuild-home/gmi_easyconfigs/HOME-0.9-foss-2017a-Python-2.7.13.eb
== fetching sources & patches for HOME-0.9-foss-2017a-Python-2.7.13.eb...
WARNING: Found existing checksums in HOME-0.9-foss-2017a-Python-2.7.13.eb, overwriting them (due to use of --force)...
== backup of easyconfig file saved to /net/gmi.oeaw.ac.at/software/mendel/easybuild-home/gmi_easyconfigs/HOME-0.9-foss-2017a-Python-2.7.13.eb.bak_20180430090822...
== injecting sha256 checksums for sources & patches in HOME-0.9-foss-2017a-Python-2.7.13.eb...
== * 0.9.tar.gz: 6cb75a2f1fa22cd1f979fcbbaf4b7c2b1e932a6aad0b332a64013be335906266
== * HOME-0.9_setup.patch: e9f05b9cd6e3732fb6d478875f8bc821ddc6e21614eb9693a43bf7754ffbb05c
== Temporary log file(s) /tmp/eb-EOFgJ6/easybuild-crdcEt.log* have been removed.
== Temporary directory /tmp/eb-EOFgJ6 has been removed.
There was a problem hiding this comment.
@timeu Did you trash the 0.9.tar.gz that EasyBuild has downlloaded before?
There was a problem hiding this comment.
@boegel : ups.. yeah I forgot that. after deleting the file and re-running the checksum injection it worked.
|
Test report by @boegel |
|
Test report by @boegel |
|
Going in, thanks @timeu! |
(created using
eb --new-pr)