Skip to content

libdrm: add pkg-config as build dependency#6243

Merged
boegel merged 1 commit intoeasybuilders:developfrom
geimer:fix_libdrm_pkg-config
Apr 26, 2018
Merged

libdrm: add pkg-config as build dependency#6243
boegel merged 1 commit intoeasybuilders:developfrom
geimer:fix_libdrm_pkg-config

Conversation

@geimer
Copy link
Copy Markdown
Contributor

@geimer geimer commented Apr 26, 2018

As discussed during yesterday's conf call, libdrm fails to build on systems where pkg-config isn't available through the OS. Thus, adding it as a build dependency.

I've only touched libdrm-2.4.88-GCCcore-6.4.0.eb and libdrm-2.4.91-GCCcore-6.4.0.eb as I don't have all the other toolchains available. However, older versions are likely to also be affected.

@geimer
Copy link
Copy Markdown
Contributor Author

geimer commented Apr 26, 2018

Test report by @geimer
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
swatc01 - Linux debian 9.3, Intel(R) Xeon(R) CPU X5660 @ 2.80GHz, Python 2.7.13
See https://gist.github.com/889947242c75e875d66e6ab8debee9cc for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 26, 2018

@geimer This is indeed also relevant to older libdrm easyconfigs. The log for all libdrm easyconfigs (up until v2.4.27) all include this in the output of configure:

checking for pkg-config... /bin/pkg-config

Thanks for tackling this for the most recent libdrm easyconfigs, we'll take a look at some of the other recent ones.

@boegel boegel added this to the 3.6.1 milestone Apr 26, 2018
@boegel boegel added the bug fix label Apr 26, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 26, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2691.swalot.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/4a9742af013be98500e1d04e91be2492 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 26, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2069.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/dd6cd21cab079ce930c4f7e26a82109d for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 26, 2018

Going in, thanks @geimer!

@boegel boegel merged commit 3c4eb62 into easybuilders:develop Apr 26, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 26, 2018

follow-up in #6244

@geimer geimer deleted the fix_libdrm_pkg-config branch April 27, 2018 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants