Skip to content

avoid that Nipype downloads dependencies for included extensions#6263

Merged
vanzod merged 2 commits intoeasybuilders:developfrom
boegel:nipype_no_downloads
May 2, 2018
Merged

avoid that Nipype downloads dependencies for included extensions#6263
vanzod merged 2 commits intoeasybuilders:developfrom
boegel:nipype_no_downloads

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 2, 2018

Since this easyconfigs set exts_download_dep_fail = True, the download detection added in easybuilders/easybuild-easyblocks#1377 will trigger a sanity check failure without listing these additional extensions explicitly...

@boegel boegel added the bug fix label May 2, 2018
@boegel boegel added this to the 3.6.1 milestone May 2, 2018
@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 2, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2411.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/cb4fbd4ed76d5d508d78dae3482d8bc7 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 2, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2065.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/c5acee2dc5d933608a588c3de924a56b for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 2, 2018

tested on top of easybuilders/easybuild-easyblocks#1377...

@vanzod vanzod mentioned this pull request May 2, 2018
Closed
@boegel boegel requested a review from vanzod May 2, 2018 16:08
@vanzod
Copy link
Copy Markdown
Member

vanzod commented May 2, 2018

Test report by @vanzod
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
cermis - Linux debian 9.4, Intel(R) Xeon(R) CPU E5620 @ 2.40GHz, Python 2.7.13
See https://gist.github.com/f8b4b739d0c2359b7fe65539df8e09d1 for a full test report.

@vanzod
Copy link
Copy Markdown
Member

vanzod commented May 2, 2018

Going in, thanks @boegel!

@vanzod vanzod merged commit bec766a into easybuilders:develop May 2, 2018
@boegel boegel deleted the nipype_no_downloads branch May 2, 2018 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpoely86 wpoely86 wpoely86 approved these changes

@vanzod vanzod vanzod approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

3.6.1

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @vanzod @wpoely86