Skip to content

{devel} [foss/2018a] libutempter v1.1.6#6426

Merged
boegel merged 6 commits intoeasybuilders:developfrom
SimonPinches:libutempter
May 3, 2019
Merged

{devel} [foss/2018a] libutempter v1.1.6#6426
boegel merged 6 commits intoeasybuilders:developfrom
SimonPinches:libutempter

Conversation

@SimonPinches
Copy link
Copy Markdown
Contributor

Some issues downloading gzipped tarball from Git repo. I did it by hand outside EasyBuild so far...

@SimonPinches SimonPinches force-pushed the libutempter branch 3 times, most recently from 39b8e0a to 130d922 Compare June 5, 2018 09:18
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jun 6, 2018

@SimonPinches Please fix the style errors reported by Travis.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 7, 2018

$ eb --from-pr 6426 --check-style
== temporary log file in case of crash /tmp/eb-hhreSU/easybuild-DqqNmZ.log

*** WARNING: Using easyconfigs from unstable (pending/failed tests or merge conflict) PR #6426 ***

Running style check on 1 easyconfig(s)...
/tmp/eb-hhreSU/files_pr6426/l/libutempter/libutempter-1.1.6.2-GCC-6.4.0-2.28.eb:12:94: E226 missing whitespace around arithmetic operator
/tmp/eb-hhreSU/files_pr6426/l/libutempter/libutempter-1.1.6.2-GCC-6.4.0-2.28.eb:12:107: E226 missing whitespace around arithmetic operator
/tmp/eb-hhreSU/files_pr6426/l/libutempter/libutempter-1.1.6.2-GCC-6.4.0-2.28.eb:12:114: E226 missing whitespace around arithmetic operator
/tmp/eb-hhreSU/files_pr6426/l/libutempter/libutempter-1.1.6.2-GCC-6.4.0-2.28.eb:12:121: E501 line too long (137 > 120 characters)
/tmp/eb-hhreSU/files_pr6426/l/libutempter/libutempter-1.1.6.2-GCC-6.4.0-2.28.eb:12:127: E226 missing whitespace around arithmetic operator
[FAIL] /tmp/eb-hhreSU/files_pr6426/l/libutempter/libutempter-1.1.6.2-GCC-6.4.0-2.28.eb
ERROR: One or more style checks FAILED!

@verdurin
Copy link
Copy Markdown
Member

Test report by @verdurin
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
easybuild.novalocal - Linux centos linux 7.5.1804, Intel Xeon E312xx (Sandy Bridge), Python 2.7.5
See https://gist.github.com/5d40770f1c70ba01296fe0fa37d5af7e for a full test report.

@verdurin
Copy link
Copy Markdown
Member

As hinted above, test build failed owing to download error.


source_urls = [
'http://git.altlinux.org/people/ldv/packages/?p=libutempter.git;a=snapshot;h=' +
version[0:5] + '-alt' + version[6:7] + ';sf=tgz']
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonPinches If this doesn't work and there's no alternative for downloading the sources, we'll need to escape with a manual download for now (but then that should be clarified with a comment that mentions the full URL).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel I've added the full download link in a comment. Perhaps you can help make the auto-download work but so far I've failed :-(

@easybuilders easybuilders deleted a comment from boegelbot Sep 15, 2018
@easybuilders easybuilders deleted a comment from boegelbot Sep 15, 2018
@easybuilders easybuilders deleted a comment from boegelbot Sep 15, 2018
# Download link: http://git.altlinux.org/people/ldv/packages/?p=libutempter.git;a=snapshot;h=1.1.6-alt2;sf=tgz
# source_urls = [
# 'http://git.altlinux.org/people/ldv/packages/?p=libutempter.git;a=snapshot;h='; +
# version[0:5] + '-alt' + version[6:7] + ';sf=tgz']
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonPinches I think we'll need to go with manual download for this one, so just including a comment like:

# download via http://git.altlinux.org/people/ldv/packages/?p=libutempter.git;a=snapshot;h=1.1.6-alt2;sf=tgz
# and rename libutempter-1.1.6-alt2-3c6e555.tar.gz to libutempter-1.1.6.2.tar.gz
sources = [{
   'filename': SOURCE_TAR_GZ,
    'extract_cmd': "tar xfvz %s --strip 1",
}]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel Done (with an extra space before 'filename').

'extract_cmd': "tar xfvz %s --strip 1",
}]

checksums = ['b7e55b666c575d8f2d294c82655b6af21f0c7339625ba6707e5edc2883a2b09a']
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonPinches Hmm, I'm getting a different checksum? de1183edd2c1ec80f93a57bc8847f9dd5d47774b78cef6c437583e3c3dae1226

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel @SimonPinches Just saw a different checksum:
8b683c355d3376b95a27180f9d710c9b06261fd68b9587c0b13fe443f267d4c5

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel @verdurin If I repeat the download and rename, then I get a different checksum again: 198092c3044c5d51bc142411b0a55b75d57207b80d99f1ee785fa4760dfb47cd
Since the original filename seems to already contain a hash, I'm surprised it's continually changing...
How should we handle this?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, that's pretty annoying... Maybe they are fingerprinting downloads or something?

Any differences between two consecutive downloads that have different checksums with unpack & diff -ru dir1 dir2?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel @verdurin The extracted tarballs are the same, it's the timestamps of the tar files that are then gzipped that causes the different hashes. If I first unzip all the various tgz files then the sha256sum of the tarballs all agree. Anyway to first unzip and then test the checksum?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the checksums are computed on the source files as specified in sources.

But, we can make unzipping part of the instructions (including a comment to explain why), and list SOURCE_TAR in sources?

@verdurin
Copy link
Copy Markdown
Member

Test report by @verdurin
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
easybuild.novalocal - Linux centos linux 7.5.1804, Intel Xeon E312xx (Sandy Bridge), Python 2.7.5
See https://gist.github.com/dce627b1a88c18ad34fabdc7c7711f0e for a full test report.

@verdurin
Copy link
Copy Markdown
Member

Test report by @verdurin
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
easybuild.novalocal - Linux centos linux 7.5.1804, Intel Xeon E312xx (Sandy Bridge), Python 2.7.5
See https://gist.github.com/be38779ac5b3c014947fb6083692ebbf for a full test report.

@SimonPinches SimonPinches changed the title {devel} [foss/2018a] libutempter v1.1.6 {WIP} {devel} [foss/2018a] libutempter v1.1.6 Oct 16, 2018
Comment thread easybuild/easyconfigs/l/libutempter/libutempter-1.1.6.2-GCC-6.4.0-2.28.eb Outdated
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 16, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
gligar02.gligar.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/38eb3230ce5487413c5603d5e9bf1c3a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 3, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3112.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/095f6f8972e6d1e6bc6b00b35e5fe247 for a full test report.

@boegel boegel added this to the next release (3.9.1) milestone May 3, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented May 3, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2606.swalot.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/25d9e662ba79fcc16e354aa7c99d40e2 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 3, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2016.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/12803f3c49189b42d44146b7e558f4fe for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 3, 2019

Going in, thanks @SimonPinches!

@boegel boegel merged commit e61d095 into easybuilders:develop May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants