enable building of MPI libraries in VTK 8.1.0 easyconfigs#6460
enable building of MPI libraries in VTK 8.1.0 easyconfigs#6460damianam merged 2 commits intoeasybuilders:developfrom
Conversation
|
Test report by @boegel |
|
Test report by @boegel |
damianam
left a comment
There was a problem hiding this comment.
Looks fine to me, but I am nitpicking a bit just to avoid randomness in lists of configopts.
| ] | ||
|
|
||
| configopts = "-DOPENGL_glu_LIBRARY=$EBROOTLIBGLU/lib/libGLU.%s " % SHLIB_EXT | ||
| configopts = "-DVTK_Group_MPI:BOOL=ON " |
There was a problem hiding this comment.
Why this particular order? I'd suggest to group by either functionality or alphabetically. Now it seems random.
There was a problem hiding this comment.
@damianam Like this it's consistent with the existing VTK 8.1.1 easyconfig, see https://github.com/easybuilders/easybuild-easyconfigs/pull/6404/files#diff-0ee45fd4c5d93b140383c1df76708f6eR48, so I prefer leaving it like this.
I have no particular reason to order the options like this though, so if you insist I'll just tweak the VTK 8.1.1 easyconfig as well to match it.
There was a problem hiding this comment.
I think it makes sense to use a sensible order, now that you are changing the easyconfig.
| configopts = "-DVTK_Group_MPI:BOOL=ON " | ||
| configopts += "-DOPENGL_glu_LIBRARY=$EBROOTLIBGLU/lib/libGLU.%s " % SHLIB_EXT | ||
| configopts += "-DOPENGL_gl_LIBRARY=$EBROOTMESA/lib/libGL.%s " % SHLIB_EXT | ||
| configopts += "-DOPENGL_INCLUDE_DIR=$EBROOTMESA/include -DVTK_WRAP_PYTHON=ON " |
| ] | ||
|
|
||
| configopts = "-DOPENGL_glu_LIBRARY=$EBROOTLIBGLU/lib/libGLU.%s " % SHLIB_EXT | ||
| configopts = "-DVTK_Group_MPI:BOOL=ON " |
There was a problem hiding this comment.
Same comments as previous file.
|
Test report by @boegel |
|
Test report by @boegel |
No description provided.