Skip to content

{bio}[intel/2018a] PRC v1.5.6#6477

Merged
boegel merged 2 commits intoeasybuilders:developfrom
smoors:20180620102739_new_pr_PRC156
Jun 20, 2018
Merged

{bio}[intel/2018a] PRC v1.5.6#6477
boegel merged 2 commits intoeasybuilders:developfrom
smoors:20180620102739_new_pr_PRC156

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Jun 20, 2018

(created using eb --new-pr)

boegel
boegel reviewed Jun 20, 2018
View reviewed changes
Comment thread easybuild/easyconfigs/p/PRC/PRC-1.5.6-intel-2018a.eb
sources = ['%(namelower)s-%(version)s-src.tgz']
checksums = ['2ad9dcd0621a7262b5754426a62cd630dfbf14b04481fde116fa169d89249394']

postinstallcmds = ["mkdir -p %(installdir)s/bin && cp prc convert_to_prc merge_aligns.pl %(installdir)s/bin"]
Copy link
Copy Markdown
Member

@boegel boegel Jun 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors So make install doesn't do anything?

Copy link
Copy Markdown
Contributor Author

@smoors smoors Jun 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it's not even defined in the makefile

Copy link
Copy Markdown
Member

@boegel boegel Jun 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors Then we should skip the install step (and maybe include a comment to explain why we're using this approach):

skipsteps = ['install']

@boegel boegel added the new label Jun 20, 2018
boegel
boegel approved these changes Jun 20, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the 3.6.2 milestone Jun 20, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 20, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
gligar01.gligar.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/65c6fcb614cbb59b1ddba62a0a7d0dc7 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 20, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2533.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/9406858821a89e281e802338ef6ab850 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 20, 2018

Going in, thanks @smoors!

@boegel boegel merged commit c04903d into easybuilders:develop Jun 20, 2018
@smoors smoors deleted the 20180620102739_new_pr_PRC156 branch January 27, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

3.6.2

Development

Successfully merging this pull request may close these issues.

2 participants

@smoors @boegel