Bugfix openmpi about osdeps etc by fgeorgatos · Pull Request #650 · easybuilders/easybuild-easyconfigs

fgeorgatos · 2013-12-27T12:14:22Z

here is an openmpi easyconfigs cleanup, triggered by the need to actually use osdeps, correctly.

The points that SHOULD be reviewed as non-trivial are:

--with-hwloc=$EBROOTHWLOC was missing from the iccifort case; bug??? if so, fixed.
Use shared_lib_ext for OpenMPI-1.6.5-GCC-4.7.2

hpcugentbot · 2013-12-27T12:14:26Z

Automatic reply from Jenkins: Can I test this?

boegel · 2013-12-27T12:23:04Z

Jenkins: ok to test

fgeorgatos · 2014-01-17T11:57:22Z

Hi,

I'd like we bump up the priority of this one, because:

if not, we keep copying asymmetric style easyconfigs, for our new PRs
if not, it prevents me (and perhaps others) from working on cleaned-up openmpi easyconfig templates, on site customizations
it is THE best place to start fiddling with easyconfig format v2.0: because of the different patches needed, since OpenMPI fellows changed the tunable options names across versions, then changed back etc (seeing is believing).

tia,
F.

fgeorgatos · 2014-01-17T11:58:20Z

ah, yeah, and also, last but not least:

folks on debian/ubuntu would be disappointed by the osdeps error message.

besserox · 2014-01-22T23:27:40Z

Why do you add dependency on IB verbs for a no-OFED build?
The '--without-openib' configure flag is used so it is actually not required.

good catch, fixed it via b37f7a8!

is the rest of the PR reasonable to you?

Signed-off-by: Fotis Georgatos <[email protected]>

besserox · 2014-01-23T13:58:39Z

Same thing here

besserox · 2014-01-23T14:06:40Z

I have not tried the builds myself, but this looks ok to me.
Nothing new, this just make all the OpenMPI easyconfigs more uniform.

Once the osdependencies are fixed for the all the no-OFED variants, i think it's good to go.

Signed-off-by: Fotis Georgatos <[email protected]>

boegel · 2014-02-11T20:18:26Z

This is something we should avoid... We want to get rid of executing Python code in easyconfigs (see the format v2 effort) and adding if-else constructs is the exact opposite...

A solution to this would be to support specifying alternatives in osdependencies, like we already have in sanity_check_paths:

osdependencies = [('libibverbs-devel', 'libibverbs-dev')]

This needs changes to the framework though, and since we're way past the freeze for EB v1.11, it'll have to wait (sorry :().

wait a sec: this is not something new, look fi. at this file:

OpenMPI-1.4.5-GCC-4.6.3.eb

This PR does not really introduce new features, just homogenizes all OpenMPI sources,
to make them amenable to 1) further git branching/diffing 2) ready for easyconfig 2.0

OK, that changes things, sorry about that. If it's already there, it makes no sense not to have it aligned across easyconfigs. Thanks for clarifying that.

ok, no problem, I got surprised for a little while ;-)

I just reverted the unused .patch, this should make this aligned to comments made so far...

I implemented the flexibility support for osdependencies, see easybuilders/easybuild-framework#846.

boegel · 2014-02-11T20:20:15Z

Jenkins: test this please

Signed-off-by: Fotis Georgatos <[email protected]>

boegel · 2014-02-11T20:33:12Z

@fgeorgatos: please don't include patches that are not used (and shouldn't be used, since they're site-specific)

sure, i understand the argument, and then that applies also for the other existing patch file;
yet, if you watch carefully though, it may help a lot newcomers, because OpenMPI is seriously annoying with the change in naming of the variable for defining the connector; to make things more interesting, more recent versions reverted back to the old style and this makes this new patch interesting… anyway, I'm cool about it, if you don't like it let's drop it

@fgeorgatos: It's not that I don't like the patch, it's just that the easyconfigs repo isn't the right place to document 'fancy hacks' (forgive me the lack of respect ;-))

'fancy hacks':

I don't bother for the lack of respect (I know I do fancy hacks anyhow, so I remain unfazed ;-)

the point is, OK, how should we share the experience of customizing the MPI stacks? I really think that users of EasyBuild ("social sysadmins") would like to share such information.

And if there is a better way to do so than the proposed patch, I'm totally eager to hear that...

With decent tools (e.g. mympirun), there's probably no need for the patch (although I haven't looked into the details, I must admit).

This is a documentation aspect, and EasyBuild isn't about documentation... Let's try and avoid making EasyBuild solve all the problems in the world. ;-)

This reverts commit e7cdefa.

boegel · 2014-02-13T10:25:06Z

I don't think we need to hold this back until easybuilders/easybuild-framework#846 is merged in (especially since there's some discussion there).

The if-else crap was already there in the OpenMPI easyconfigs, this just aligns things. so good to go.

Thanks for the effort @fgeorgatos!

Bugfix openmpi about osdeps etc

fgeorgatos · 2014-02-13T12:27:48Z

OK, good to hear this, since we can now provide site customizations over a quite decent base!
(I mean, consistent, so that there is good symmetry in the diffs), ty!

fgeorgatos added 6 commits December 26, 2013 09:04

fix osdependencies all along openmpi

79e4661

style fixes only on openmpi easyconfigs

4a6815e

EBROOTHWLOC was missing from OpenMPI-1.6.3-iccifort-2011.13.367

7d3e6d2

more style fixes

272e939

fix shared_lib extensions

ad942ae

mroe style fixes

0e02c78

besserox reviewed Jan 22, 2014
View reviewed changes

-no-OFED does not care about libib packages

b37f7a8

Signed-off-by: Fotis Georgatos <[email protected]>

besserox reviewed Jan 23, 2014
View reviewed changes

Comment thread easybuild/easyconfigs/o/OpenMPI/OpenMPI-1.6.5-GCC-4.7.3-no-OFED.eb Outdated

Copy link
Copy Markdown

Contributor

besserox Jan 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here

no-OFEDs, no ib, simple

ac18711

Signed-off-by: Fotis Georgatos <[email protected]>

boegel reviewed Feb 11, 2014
View reviewed changes

add patch for v1.4.5, to show openmpi fancyness

e7cdefa

Signed-off-by: Fotis Georgatos <[email protected]>

boegel reviewed Feb 11, 2014
View reviewed changes

Revert "add patch for v1.4.5, to show openmpi fancyness"

d4560c5

This reverts commit e7cdefa.

boegel added a commit that referenced this pull request Feb 13, 2014

Merge pull request #650 from fgeorgatos/bugfix_openmpi_osdeps

46dd500

Bugfix openmpi about osdeps etc

boegel merged commit 46dd500 into easybuilders:develop Feb 13, 2014

fgeorgatos deleted the bugfix_openmpi_osdeps branch February 13, 2014 12:26

Conversation

fgeorgatos commented Dec 27, 2013

Uh oh!

hpcugentbot commented Dec 27, 2013

Uh oh!

boegel commented Dec 27, 2013

Uh oh!

fgeorgatos commented Jan 17, 2014

Uh oh!

fgeorgatos commented Jan 17, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

besserox commented Jan 23, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

boegel commented Feb 11, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

boegel commented Feb 13, 2014

Uh oh!

fgeorgatos commented Feb 13, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants