{devel}[foss/2017a] makedepf90 2.8.8#6504
{devel}[foss/2017a] makedepf90 2.8.8#6504migueldiascosta merged 5 commits intoeasybuilders:developfrom dplacencia:makedepf90
Conversation
|
Test report by @migueldiascosta |
|
@dplacencia is there a specific reason to use such and old toolchain here (and in #6503)? |
|
|
||
| toolchain = {'name': 'foss', 'version': '2015a'} | ||
|
|
||
| sources = ['makedepf90_2.8.8.orig.tar.gz'] |
There was a problem hiding this comment.
please use templates (e.g. '%(name)s_%(version)s.orig.tar.gz')
| toolchain = {'name': 'foss', 'version': '2015a'} | ||
|
|
||
| sources = ['makedepf90_2.8.8.orig.tar.gz'] | ||
| source_urls = ['https://launchpad.net/ubuntu/+archive/primary/+sourcefiles/makedepf90/2.8.8-1/'] |
|
|
||
| prebuildopts = 'make depend;' | ||
|
|
||
| patches = [] |
|
|
||
| patches = [] | ||
|
|
||
| dependencies = [] |
| name = 'makedepf90' | ||
| version = '2.8.8' | ||
|
|
||
| homepage = 'http://www.iki.fi/erik.edelmann/makedepf90' |
There was a problem hiding this comment.
url doesn't exist anymore, is there another one?
There was a problem hiding this comment.
Hi. That url is the one that appears in official sources, but since it is not available I think it will be better to leave it empty because I did not find another official page.
There was a problem hiding this comment.
Or ask Erik where it is now if it still exists.
There was a problem hiding this comment.
Following your suggestion I just wrote to Erik right now, thanks for the suggestion akesandgren.
There was a problem hiding this comment.
Hi. I need to know if any other change is necessary in this easyblock. Well, I'm waiting for it to be accepted in order to continue working in another (FVCOM)
|
Hi. I need to know if any other change is necessary in this easyblock. Well, I'm waiting for it to be accepted in order to continue working in another (FVCOM) |
|
@dplacencia sorry, had missed your earlier comment. There are now two easyconfigs, one for 2015a, unchanged, and another for 2017a, was that intended or did you mean to replace the older one? |
|
The objective was to replace the previous one. Following his subject, I used a more current toolchain and made some changes. If any other changes are necessary, please tell me. Thank you |
boegel
left a comment
There was a problem hiding this comment.
@dplacencia Please remove the other easyconfig file with the old toolchain (git rm easybuild/easyconfigs/m/makedepf90/makedepf90-2.8.8-foss-2015a.eb)
| name = 'makedepf90' | ||
| version = '2.8.8' | ||
|
|
||
| homepage = '' |
There was a problem hiding this comment.
@dplacencia How about using https://linux.die.net/man/1/makedepf90 instead? Better than leaving it empty imho...
| toolchain = {'name': 'foss', 'version': '2017a'} | ||
|
|
||
| sources = ['%(name)s_%(version)s.orig.tar.gz'] | ||
| source_urls = ['https://launchpad.net/ubuntu/+archive/primary/+sourcefiles/%(name)s/%(version)s-1/'] |
There was a problem hiding this comment.
@dplacencia Please include a SHA256 checksum, eb makedepf90-2.8.8-foss-2017a.eb --inject-checksums will do this for you
|
|
||
| prebuildopts = 'make depend;' | ||
|
|
||
|
|
There was a problem hiding this comment.
@dplacencia Style nitpicking: please drop duplicate empty line
| source_urls = ['https://launchpad.net/ubuntu/+archive/primary/+sourcefiles/%(name)s/%(version)s-1/'] | ||
| checksums = ['a5118aea198219f59bc04eab0a2099341cecac76a7029c2aef72141645e7596a'] | ||
|
|
||
| prebuildopts = 'make depend;' |
There was a problem hiding this comment.
@dplacencia I overlooked this in the previous review sorry...
Please change this to 'make depend && ', i.e. fail early if the make depend fails
|
@migueldiascosta Good to go now? |
|
Test report by @boegel |
|
Test report by @boegel |
|
Thanks for the review. Any other change? |
|
@dplacencia OK for me, I'll let @migueldiascosta take another look |
|
Test report by @migueldiascosta |
|
Going in, thanks @dplacencia! |
Support for makedepf90