Skip to content

Added tabix dependency in VCFtools#6584

Merged
bartoldeman merged 2 commits intoeasybuilders:developfrom
vanzod:20180713095336_new_pr_VCFtools0111
Jul 24, 2018
Merged

Added tabix dependency in VCFtools#6584
bartoldeman merged 2 commits intoeasybuilders:developfrom
vanzod:20180713095336_new_pr_VCFtools0111

Conversation

@vanzod
Copy link
Copy Markdown
Member

@vanzod vanzod commented Jul 13, 2018

(created using eb --new-pr)

@vanzod vanzod added this to the 3.6.3 milestone Jul 13, 2018
@vanzod vanzod changed the title Added tabix dependency Added tabix dependency in VCFtools Jul 13, 2018
@vanzod
Copy link
Copy Markdown
Member Author

vanzod commented Jul 13, 2018

See #6583

@bartoldeman bartoldeman self-assigned this Jul 13, 2018
@bartoldeman bartoldeman self-requested a review July 13, 2018 17:17
@bartoldeman
Copy link
Copy Markdown
Contributor

bartoldeman commented Jul 18, 2018

Test report by @bartoldeman
SUCCESS
Build succeeded for 4 out of 4 (1 easyconfigs in this PR)
aw-4r14-n02 - Linux centos 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/d53e88744bd8bcb532feec22cedf89be for a full test report.

bartoldeman
bartoldeman reviewed Jul 18, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me but it will take a while to test all of them as I don't have all those toolchains installed yet!

@bartoldeman
Copy link
Copy Markdown
Contributor

bartoldeman commented Jul 18, 2018

Test report by @bartoldeman
SUCCESS
Build succeeded for 3 out of 3 (1 easyconfigs in this PR)
aw-4r14-n02 - Linux centos 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/f972eb79ef2e8f0331a825a978060837 for a full test report.

@vanzod
Copy link
Copy Markdown
Member Author

vanzod commented Jul 18, 2018

@bartoldeman That is the same reason I have not uploaded a test report either. It can wait until @boegel comes back.

@bartoldeman
Copy link
Copy Markdown
Contributor

bartoldeman commented Jul 23, 2018

Test report by @bartoldeman
FAILED
Build succeeded for 27 out of 40 (16 easyconfigs in this PR)
aw-4r14-n02 - Linux centos 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/d240ca111a42b2e14fb335defef671ca for a full test report.

@bartoldeman
Copy link
Copy Markdown
Contributor

bartoldeman commented Jul 23, 2018

Test report by @bartoldeman
FAILED
Build succeeded for 4 out of 7 (16 easyconfigs in this PR)
aw-4r14-n02 - Linux centos 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/851a10482811017199831013f4626eda for a full test report.

@bartoldeman
Copy link
Copy Markdown
Contributor

bartoldeman commented Jul 23, 2018

I managed to build all the dependencies. There was only trouble with zlib in VCFtools. You can fix that by adding this to the 0.1.11 and 0.1.12 VCFtools easyconfigs (newer use ConfigureMake, no problem there):

buildopts = 'LIB="-L$EBROOTZLIB/lib -lz"'

@bartoldeman
Copy link
Copy Markdown
Contributor

bartoldeman commented Jul 24, 2018

Test report by @bartoldeman
SUCCESS
Build succeeded for 16 out of 16 (16 easyconfigs in this PR)
aw-4r14-n02 - Linux centos 6.6, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/6e7240771aea808464cb8e9698b94f58 for a full test report.

bartoldeman
bartoldeman approved these changes Jul 24, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now, going on @vanzod !

@bartoldeman bartoldeman merged commit ee46fcd into easybuilders:develop Jul 24, 2018
@bartoldeman bartoldeman mentioned this pull request Jul 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartoldeman bartoldeman bartoldeman approved these changes

Assignees

@bartoldeman bartoldeman

Labels

bug fix update

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@vanzod @bartoldeman