Skip to content

{tools}[foss/2018a] mordecai v2.0.1#6670

Merged
boegel merged 5 commits intoeasybuilders:developfrom
akesandgren:20180809212234_new_pr_mordecai201
Aug 15, 2018
Merged

{tools}[foss/2018a] mordecai v2.0.1#6670
boegel merged 5 commits intoeasybuilders:developfrom
akesandgren:20180809212234_new_pr_mordecai201

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren commented Aug 9, 2018

(created using eb --new-pr)
A code for full text geoparsing as a Python library.

@akesandgren akesandgren added the new label Aug 9, 2018
@akesandgren akesandgren added this to the 3.6.3 milestone Aug 9, 2018
@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Aug 10, 2018

Test report by @akesandgren
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
b-an03.hpc2n.umu.se - Linux ubuntu 16.04, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 2.7.12
See https://gist.github.com/3401099dfd8d34bcf5081a020643d688 for a full test report.

@akesandgren akesandgren reopened this Aug 10, 2018
@easybuilders easybuilders deleted a comment from boegelbot Aug 11, 2018
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Aug 15, 2018

Test report by @verdurin
FAILED
Build succeeded for 8 out of 9 (1 easyconfigs in this PR)
easybuild.novalocal - Linux centos linux 7.5.1804, Intel Xeon E312xx (Sandy Bridge), Python 2.7.5
See https://gist.github.com/f69bfaa391998281df0017b1baf8a1aa for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Aug 15, 2018 •
edited
Loading

Hmm. This happens:

== 2018-08-15 12:23:50,646 easyconfig.py:1215 WARNING Unable to resolve template value https://pypi.python.org/packages/source/%(nameletter)s/%(name)s 
with dict {'version': '2.0.1', 'name': 'mordecai', 'options': {'checksums': ['c417f343eac29eccc8af0b5cacb47da8d17bfc4dd4187d3fa193828622b5372c',
 'a52cf0b3ea4ac61c250a011c61a186644b2ade8f2adefc1560654d03c574dccf'], 'patches': ['mordecai-2.0.1_fix_bad_path_handling.patch'], 'source_urls': 
['https://pypi.python.org/packages/source/%(nameletter)s/%(name)s']}}

which then means the downloads fail.

@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Aug 15, 2018 •
edited
Loading

Strange, I don't remember having any problems with that.

I'll remove the download and try again

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Aug 15, 2018

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
easybuild.novalocal - Linux centos linux 7.5.1804, Intel Xeon E312xx (Sandy Bridge), Python 2.7.5
See https://gist.github.com/29e95fc9031126cb994c35ffdf9a1634 for a full test report.

boegel
boegel requested changes Aug 15, 2018
View reviewed changes
Comment thread easybuild/easyconfigs/m/mordecai/mordecai-2.0.1-foss-2018a-Python-3.6.4.eb Outdated
exts_download_dep_fail = True

pyver = '3.6.4'
pymajmin = ''.join(pyver.split('.')[:2])
Copy link
Copy Markdown
Member

@boegel boegel Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akesandgren Minor cleanup: pymajmin isn't used anywhere, so just remove?

And then there's no need for pyver anymore either, just specify '3.6.4' directly in dependencies for 'Python'?

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 15, 2018

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (1 easyconfigs in this PR)
node2459.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/75fcc0fd2b6156e29dc8eb1f326ec5d1 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 15, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
gligar02.gligar.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/e4169e6b9d466a28e0f429d30250e838 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 15, 2018

Test report by @boegel
SUCCESS
Build succeeded for 12 out of 12 (1 easyconfigs in this PR)
node3123.skitty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/859407811e722d2f89db1996d6dd4852 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 15, 2018

Going in, thanks @akesandgren!

@boegel boegel merged commit fc8ac0e into easybuilders:develop Aug 15, 2018
@akesandgren akesandgren deleted the 20180809212234_new_pr_mordecai201 branch August 15, 2018 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@akesandgren @verdurin @boegel