Skip to content

{bio}[GCCcore/6.4.0,Perl/5.26.1] alleleCount v4.0.0#6676

Merged
boegel merged 6 commits intoeasybuilders:developfrom
jdemeul:20180811163450_new_pr_alleleCount400
Aug 15, 2018
Merged

{bio}[GCCcore/6.4.0,Perl/5.26.1] alleleCount v4.0.0#6676
boegel merged 6 commits intoeasybuilders:developfrom
jdemeul:20180811163450_new_pr_alleleCount400

Conversation

@jdemeul
Copy link
Copy Markdown
Contributor

@jdemeul jdemeul commented Aug 11, 2018

(created using eb --new-pr)

@easybuilders easybuilders deleted a comment from boegelbot Aug 13, 2018
@boegel boegel added the new label Aug 13, 2018
@boegel boegel added this to the 3.6.3 milestone Aug 13, 2018
boegel
boegel requested changes Aug 13, 2018
View reviewed changes
Comment thread easybuild/easyconfigs/a/alleleCount/alleleCount-4.0.0-GCCcore-6.4.0.eb
]

modextrapaths = {'PERL5LIB': 'lib/perl5'}

Copy link
Copy Markdown
Member

@boegel boegel Aug 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdemeul Please include a custom sanity_check_paths where you list a couple of expected files/directories that should get installed.

Comment thread easybuild/easyconfigs/a/alleleCount/alleleCount-4.0.0-GCCcore-6.4.0.eb

# HTSlib 1.7 is built, used and removed again in the provided setup script
dependencies = [
('Perl', '5.26.1')
Copy link
Copy Markdown
Member

@boegel boegel Aug 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdemeul Looks like cURL is missing as a dependency, since I'm running into errors like:

configure: error: libcurl library not found

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Aug 13, 2018

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
rescomp2 - Linux centos 6.8, Intel(R) Xeon(R) CPU E5-2650 v2 @ 2.60GHz, Python 2.7.11
See https://gist.github.com/d83950081c2e22178b6ef1d3d7464732 for a full test report.

verdurin
verdurin previously approved these changes Aug 13, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 14, 2018

@jdemeul Trivial style issues:

$ eb --check-style --from-pr 6676
== temporary log file in case of crash /tmp/eb-RBc7K3/easybuild-AetgiC.log

*** WARNING: Using easyconfigs from unstable (pending/failed tests or merge conflict) PR #6676 ***

Running style check on 1 easyconfig(s)...
/tmp/eb-RBc7K3/files_pr6676/a/alleleCount/alleleCount-4.0.0-GCCcore-6.4.0.eb:28:23: W299 trailing whitespace
/tmp/eb-RBc7K3/files_pr6676/a/alleleCount/alleleCount-4.0.0-GCCcore-6.4.0.eb:33:23: W299 trailing whitespace
[FAIL] /tmp/eb-RBc7K3/files_pr6676/a/alleleCount/alleleCount-4.0.0-GCCcore-6.4.0.eb
ERROR: One or more style checks FAILED!

@easybuilders easybuilders deleted a comment from boegelbot Aug 15, 2018
@easybuilders easybuilders deleted a comment from boegelbot Aug 15, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 15, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3123.skitty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/e2b6caf315919f90dfcf06e5fed26f41 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 15, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2419.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/97aa580970cc312e28b240dd81bf13eb for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 15, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
gligar03.gligar.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/15238a88e750b50d11788c6ace042c8a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 15, 2018

Going in, thanks @jdemeul!

@boegel boegel merged commit e78becc into easybuilders:develop Aug 15, 2018
@boegel boegel mentioned this pull request Sep 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@verdurin verdurin verdurin left review comments

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jdemeul @verdurin @boegel