Skip to content

{data}[foss/2018a] datamash 1.3#6693

Merged
boegel merged 5 commits intoeasybuilders:developfrom
PiotrCM:branch997
Dec 14, 2018
Merged

{data}[foss/2018a] datamash 1.3#6693
boegel merged 5 commits intoeasybuilders:developfrom
PiotrCM:branch997

Conversation

@PiotrCM
Copy link
Copy Markdown
Contributor

@PiotrCM PiotrCM commented Aug 14, 2018

No description provided.

@PiotrCM
Copy link
Copy Markdown
Contributor Author

PiotrCM commented Aug 14, 2018

#6693

boegel
boegel requested changes Aug 14, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @PiotrCM!

Please take a look at the minor suggestions, and remove the faulty Datamash-1.3-foss-2018a.eb easyconfig file. You can use --update-pr for this, by marking the file to remove with a :, as follows:

eb --update-pr 6693 :easybuild/easyconfigs/d/datamash/Datamash-1.3-foss-2018a.eb

Comment thread easybuild/easyconfigs/d/datamash/Datamash-1.3-foss-2018a.eb Outdated
Comment thread easybuild/easyconfigs/d/datamash/Datamash-1.3-foss-2018a.eb Outdated
Comment thread easybuild/easyconfigs/d/datamash/datamash-1.3-foss-2018a.eb Outdated
Comment thread easybuild/easyconfigs/d/datamash/datamash-1.3-foss-2018a.eb Outdated
Comment thread easybuild/easyconfigs/d/datamash/datamash-1.3-foss-2018a.eb Outdated
Comment thread easybuild/easyconfigs/d/datamash/datamash-1.3-foss-2018a.eb
@boegel boegel added this to the 3.6.3 milestone Aug 14, 2018
@boegel boegel added the new label Aug 14, 2018
@easybuilders easybuilders deleted a comment from boegelbot Aug 15, 2018
@easybuilders easybuilders deleted a comment from boegelbot Aug 15, 2018
boegel
boegel requested changes Aug 15, 2018
View reviewed changes
Comment thread easybuild/easyconfigs/d/datamash/datamash-1.3-foss-2018a.eb Outdated
@boegel boegel changed the title support for datamash {data}[foss/2018a] datamash 1.3 Aug 15, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 15, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2469.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/8bf94ae93131a7525159f686debcf556 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 15, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2110.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/aff3409843c7d0b1f6edc425d007e790 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 15, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3123.skitty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/6c3e7386b672ea5b3a7fc8924a20d5a4 for a full test report.

@boegel boegel modified the milestones: 3.7.0, next release Sep 22, 2018
@boegel boegel modified the milestones: 3.7.1, next release Oct 10, 2018
@easybuilders easybuilders deleted a comment from boegelbot Dec 14, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 14, 2018

Going in, thanks @PiotrCM!

@boegel boegel merged commit e4fc3c7 into easybuilders:develop Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@PiotrCM @boegel